Review Request 125063: fix for Bug 260869

2015-09-09 Thread Raphael Kugelmann
the written test above cannot be performed anymore. The Fail case cannot be reached anymore. Thanks, Raphael Kugelmann ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125063: fix for Bug 260869

2015-09-09 Thread Raphael Kugelmann
fix makes the mainwindow not editable while the settings dialog is open. Therefore the written test above cannot be performed anymore. The Fail case cannot be reached anymore. Thanks, Raphael Kugelmann ___ Plasma-devel mailing list Plasma-devel@kde.

Re: Review Request 125063: fix for Bug 260869

2015-09-09 Thread Raphael Kugelmann
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125063/#review85064 --- On Sept. 9, 2015, 8:26 nachm., Raphael Kugelmann wrote: > > ---

Re: Review Request 125063: fix for Bug 260869

2015-09-09 Thread Raphael Kugelmann
> On Sept. 9, 2015, 7:26 nachm., Martin Klapetek wrote: > > > > Martin Klapetek wrote: > Btw. do you have commit access? > > Raphael Kugelmann wrote: > I haven't tried it yet. > But I think I have no further access rights for the repo. sorry f

Re: Review Request 125063: fix for Bug 260869

2015-09-09 Thread Raphael Kugelmann
> On Sept. 9, 2015, 7:26 nachm., Martin Klapetek wrote: > > > > Martin Klapetek wrote: > Btw. do you have commit access? > > Raphael Kugelmann wrote: > I haven't tried it yet. > But I think I have no further access rights for the repo. > >

Re: Review Request 125063: fix for Bug 260869

2015-09-09 Thread Raphael Kugelmann
marked as submitted. Review request for Plasma. Changes --- Submitted with commit cee5e903812b5d2fae9e5be52440b8056626e95f by Martin Klapetek on behalf of Raphael Kugelmann to branch Plasma/5.4. Repository: ksysguard Description --- Bugfix for Bug 260869 - [steps] System Monitor

Review Request 125416: BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" (affected SensorType: DancingBars)

2015-09-26 Thread Raphael Kugelmann
e07eac266d Diff: https://git.reviewboard.kde.org/r/125416/diff/ Testing --- Tested - no crash anymore - the remaining sensors are the one as expected Thanks, Raphael Kugelmann ___ Plasma-devel mailing list Plasma-devel@kde.org https://ma

Re: Review Request 125416: BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" (affected SensorType: DancingBars)

2015-09-26 Thread Raphael Kugelmann
Settings.h 27df0666db53621ecddb2e4763b26509103f7381 gui/SensorDisplayLib/DancingBarsSettings.cpp 6eb9c21b1670b028570e3826620b98e07eac266d Diff: https://git.reviewboard.kde.org/r/125416/diff/ Testing --- Tested - no crash anymore - the remaining sensors are the one as expected Thanks, Raphael

Re: Review Request 125416: BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" (affected SensorType: DancingBars)

2015-09-29 Thread Raphael Kugelmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125416/#review86121 --- Ship it! Ship It! - Raphael Kugelmann On Sept. 26, 2015

Re: Review Request 125416: BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" (affected SensorType: DancingBars)

2015-09-29 Thread Raphael Kugelmann
/r/125416/#review86031 --- On Sept. 26, 2015, 11:05 nachm., Raphael Kugelmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.

Re: Review Request 125416: BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" (affected SensorType: DancingBars)

2015-10-09 Thread Raphael Kugelmann
s expected Thanks, Raphael Kugelmann ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125416: BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" (affected SensorType: DancingBars)

2015-10-22 Thread Raphael Kugelmann
r/125416/#review87231 --- On Okt. 9, 2015, 3:43 nachm., Raphael Kugelmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 125416: BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" (affected SensorType: DancingBars)

2016-09-15 Thread Raphael Kugelmann
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 70e339f3d0d0aff16559f198ac4c6dc5f6c90111 by David Edmundson on behalf of Raphael Kugelmann to branch master. Bugs: 328807 https://bugs.kde.org/show_bug.cgi?id=328807 Repository: ksysguard