Re: folderview broken

2011-12-20 Thread Shantanu Tushar
On Tuesday 20 Dec 2011 9:06:59 PM Zé wrote: 2011/12/20 Shantanu Tushar Jha shaan...@gmail.com: Hi, For the debug messages Sujith is asking, can you try the following and pastebin/attach the output, 1. run kdebugdialog and check all the checkboxes and press ok 2. run

Re: Review Request: libs/mediacenter/CMakeLists.txt: find Taglib properly

2012-11-07 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107247/#review21577 --- Ship it! Ship It! - Shantanu Tushar On Nov. 7, 2012, 4:53

Re: Review Request: Reusable qml components for mediabrowsing

2012-12-25 Thread Shantanu Tushar
://git.reviewboard.kde.org/r/107861/#comment18232 will this not be used? If yes, remove it - Shantanu Tushar On Dec. 23, 2012, 8:33 a.m., Fabian Riethmayer wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 110475: Fixed::Bug 319626 - Can't remove an another song from playlist without stopping the current media.

2013-05-16 Thread Shantanu Tushar
? mediaelements/playlist/PlaylistDelegate.qml http://git.reviewboard.kde.org/r/110475/#comment24294 don't use comments, just remove the line - Shantanu Tushar On May 16, 2013, 5:07 p.m., Akshay Ratan wrote: --- This is an automatically

Re: Review Request 110604: Drag and Drop feature to remove items from playlist added.

2013-05-23 Thread Shantanu Tushar
://git.reviewboard.kde.org/r/110604/#comment24433 please use listViewItem.ListView.view.model.currentIndex instead of playlistModel. This helps in being agnostic about the model. - Shantanu Tushar On May 23, 2013, 8:16 a.m., saurabh jain wrote

Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.

2013-05-23 Thread Shantanu Tushar
for the source index. http://qt-project.org/doc/qt-4.8/qabstractitemmodel.html#beginMoveRows - Shantanu Tushar On May 23, 2013, 7:36 p.m., saurabh jain wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 110629: Feature: Dimming the image when it is not viewed directly

2013-05-24 Thread Shantanu Tushar
://git.reviewboard.kde.org/r/110629/#comment24462 better like this- opacity = mediaBrowser.visible ? 0.25 : 1 - Shantanu Tushar On May 24, 2013, 7:46 a.m., Akshay Ratan wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 110628: Feature: Press Escape Key to navigate back one level while viewing pictures in the slideshow in the Image Viewer of the Plasma Media Center.

2013-05-24 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110628/#review33100 --- Ship it! Ship It! - Shantanu Tushar On May 24, 2013, 6:36

Re: Review Request 110629: Feature: Dimming the image when it is not viewed directly

2013-05-24 Thread Shantanu Tushar
://git.reviewboard.kde.org/r/110629/#comment24463 there should be a newline after '{' shells/newshell/package/contents/ui/mediacenter.qml http://git.reviewboard.kde.org/r/110629/#comment24464 missing indentation - Shantanu Tushar On May 24, 2013, 7:46 a.m., Akshay Ratan wrote

Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.

2013-05-24 Thread Shantanu Tushar
, 2013, 7:20 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Description --- Reordering of the songs in the playlist is now possible using this patch. Just drag and drop the item to the desired place (where you want to replace it with the item at desired

Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.

2013-05-24 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110621/#review33106 --- Ship it! Ship It! - Shantanu Tushar On May 24, 2013, 7:34

Re: Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

2013-06-02 Thread Shantanu Tushar
://git.reviewboard.kde.org/r/110776/#comment24811 no need of the { .. } block, just say onClicked: emptyAreaClicked() mediaelements/mediawelcome/MediaWelcome.qml http://git.reviewboard.kde.org/r/110776/#comment24812 same as above - Shantanu Tushar On June 1, 2013, 9:59 p.m., Akshay Ratan wrote

Re: Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

2013-06-02 Thread Shantanu Tushar
pushing your changes, shells/newshell/package/contents/ui/mediacenter.qml http://git.reviewboard.kde.org/r/110776/#comment24817 I have made some fixes around this area, you might get conflicts, make sure you keep my changes as well. - Shantanu Tushar On June 2, 2013, 4:50 p.m., Akshay Ratan

Re: Review Request 110856: A minor fix to make the Back button on the Media Controller of the PMC work when the user clicks on the empty homescreen space to open up the slideshow again.

2013-06-06 Thread Shantanu Tushar
with logging into picasa, going inside any album and then clicking back, it should take you back to your albums list, not homescreen. - Shantanu Tushar On June 6, 2013, 9:23 p.m., Akshay Ratan wrote: --- This is an automatically generated

Re: Review Request 110629: Feature: Dimming the image when it is not viewed directly

2013-06-12 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110629/#review34245 --- Ship it! Ship It! - Shantanu Tushar On June 12, 2013, 6:02

Re: Review Request 111017: Fix:Playlist Entries swap

2013-06-14 Thread Shantanu Tushar
. The press and hold and those interactive lines were there for that very reason. - Shantanu Tushar On June 14, 2013, 7:15 a.m., Akshay Ratan wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 111035: Merging sinny-youtube branch to master

2013-06-15 Thread Shantanu Tushar
/youtubebackend.cpp http://git.reviewboard.kde.org/r/111035/#comment25264 else is not needed - Shantanu Tushar On June 15, 2013, 6:11 a.m., Sinny Kumari wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 111035: Merging sinny-youtube branch to master

2013-06-15 Thread Shantanu Tushar
pushing browsingbackends/onlineservices/youtube/videodetailsmodel.h http://git.reviewboard.kde.org/r/111035/#comment25265 even this would be const ref - Shantanu Tushar On June 15, 2013, 6:15 p.m., Sinny Kumari wrote

Review Request 111047: Handle edge cases when going back/escape

2013-06-16 Thread Shantanu Tushar
://git.reviewboard.kde.org/r/111047/diff/ Testing --- Tested some scenarios that I could think of. Please test few scenarios and see if this works. Akshay: I think the new if conditions make previousBackend necessary, please check that your feature still works fine. Thanks, Shantanu Tushar

Re: Review Request 111047: Handle edge cases when going back/escape

2013-06-16 Thread Shantanu Tushar
if this works. Akshay: I think the new if conditions make previousBackend necessary, please check that your feature still works fine. Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Re: Review Request 111047: Handle edge cases when going back/escape

2013-06-19 Thread Shantanu Tushar
://git.reviewboard.kde.org/r/111047/diff/ Testing --- Tested some scenarios that I could think of. Please test few scenarios and see if this works. Akshay: I think the new if conditions make previousBackend necessary, please check that your feature still works fine. Thanks, Shantanu Tushar

Re: Review Request 111047: Handle edge cases when going back/escape

2013-06-20 Thread Shantanu Tushar
previousBackend necessary, please check that your feature still works fine. Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Shantanu Tushar
/mainwindow.cpp 113748e shells/newshell/package/contents/ui/mediacenter.qml d533b60 Diff: http://git.reviewboard.kde.org/r/87/diff/ Testing --- Tested in my branch pagestack-shantanu, works awesome. Thanks, Shantanu Tushar ___ Plasma-devel mailing

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Shantanu Tushar
shells/newshell/mainwindow.cpp 113748e shells/newshell/package/contents/ui/mediacenter.qml d533b60 Diff: http://git.reviewboard.kde.org/r/87/diff/ Testing --- Tested in my branch pagestack-shantanu, works awesome. Thanks, Shantanu Tushar

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Shantanu Tushar
113748e shells/newshell/package/contents/ui/mediacenter.qml d533b60 Diff: http://git.reviewboard.kde.org/r/87/diff/ Testing --- Tested in my branch pagestack-shantanu, works awesome. Thanks, Shantanu Tushar ___ Plasma-devel mailing list

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Shantanu Tushar
--- On June 23, 2013, 2:26 p.m., Shantanu Tushar wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/87

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-24 Thread Shantanu Tushar
://bugs.kde.org/show_bug.cgi?id=318816 . Opening associated audio/video file in PMC, first homescreen appear then playlist and then video is visible. It looks little awkward. Expected behaviour: Only video player should be visible Shantanu Tushar wrote: There might be users who expect

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-25 Thread Shantanu Tushar
. Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 111263: Revamping the filesystem browser in the plasma-mediacenter

2013-06-27 Thread Shantanu Tushar
/111263/#comment25760 placesModel, plural - Shantanu Tushar On June 26, 2013, 7:22 p.m., Akshay Ratan wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111263

Re: Review Request 111287: Fix of an issue in Escape Key functioning

2013-06-28 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111287/#review35241 --- Ship it! Ship It! - Shantanu Tushar On June 28, 2013, 7:51

Re: Review Request 111337: Enhancements and optimization in navigation flow of Plasma Media Center

2013-07-02 Thread Shantanu Tushar
. - Shantanu Tushar On July 2, 2013, 4:48 p.m., Akshay Ratan wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111337

Re: Review Request 111770: Implemented search feature in Local Browsing.

2013-07-29 Thread Shantanu Tushar
, remove it browsingbackends/localfiles/localfilesabstractmodel.cpp http://git.reviewboard.kde.org/r/111770/#comment27125 Here as well - Shantanu Tushar On July 28, 2013, 8:08 p.m., Akshay Ratan wrote: --- This is an automatically

Re: Review Request 111863: Feature: Folder Preview in Local Pictures Browsing

2013-08-08 Thread Shantanu Tushar
to be fixed - Shantanu Tushar On Aug. 8, 2013, 2:30 p.m., Akshay Ratan wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111863

Review Request 112105: [1.1] PMC fix for KDE 4.11 - prevent deletion of popped pages from PageStack

2013-08-15 Thread Shantanu Tushar
going back/into some mode. Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114110: Prints time in the lower right corner

2013-11-25 Thread Shantanu Tushar
= hours % 12; - Shantanu Tushar On Nov. 25, 2013, 3:12 p.m., Oskar Jauch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114110

Re: Review Request 114110: Prints time in the lower right corner

2013-11-25 Thread Shantanu Tushar
/114110/ --- (Updated Nov. 25, 2013, 3:12 p.m.) Review request for Plasma and Shantanu Tushar. Repository: plasma-mediacenter Description --- Shows time in the lower right corner in 12 hours format in the Plasma

Re: Review Request 114152: [GCI] FixPicturestrip navigation loop

2013-11-27 Thread Shantanu Tushar
On Nov. 27, 2013, 3:25 p.m., Sinny Kumari wrote: Thank you for patch! Please make changes as Sebastian suggested :) Other than that, there is one issue with this patch. This patch works fine in case of All pictures, Flickr and Picasa backend but it maynot work as expected in case

Re: Review Request 114152: [GCI] FixPicturestrip navigation loop

2013-11-27 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114152/#review44596 --- Ship it! Ship It! - Shantanu Tushar On Nov. 27, 2013, 4:02

Re: Review Request 114223: Moving popupmenu to mediacenter and making it more generic

2013-11-30 Thread Shantanu Tushar
/mediacenter.qml http://git.reviewboard.kde.org/r/114223/#comment32081 This is why choosing the Cancel option does nothing. You should call root.goBack() here. - Shantanu Tushar On Nov. 30, 2013, 1:54 p.m., Sujith Haridasan wrote

Re: Review Request 114223: Moving popupmenu to mediacenter and making it more generic

2013-11-30 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114223/#review44898 --- Ship it! Ship It! - Shantanu Tushar On Nov. 30, 2013, 5:07

Re: Review Request 114318: Adding keyboard navigation support for popupmenu.

2013-12-05 Thread Shantanu Tushar
/mediacenter.qml http://git.reviewboard.kde.org/r/114318/#comment32313 looks like there is no real change in this file, please only commit this if needed - Shantanu Tushar On Dec. 5, 2013, 5:35 p.m., Sujith Haridasan wrote

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Shantanu Tushar
/ --- (Updated Dec. 13, 2013, 7:24 a.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Replaced Text {} by PlasmaComponents.Label {} Diffs

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114428/#review45662 --- Ship it! Ship It! - Shantanu Tushar On Dec. 13, 2013, 3:05

Re: Review Request 114429: use of time data engine - less code

2013-12-14 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/#review45674 --- Ship it! Ship It! - Shantanu Tushar On Dec. 13, 2013, 3:01

Re: Review Request 114482: Plasma-mediacenter remember last played playlist

2013-12-15 Thread Shantanu Tushar
, it resets back to 0, most probably because ListView does that after delegates are initialized. Using the Timer was the only way I could suggest Sujith right now :( - Shantanu Tushar On Dec. 15, 2013, 5:35 p.m., Sujith Haridasan wrote

[plasma-mediacenter] mediaelements/playlist: Revert PMC remembers the last playlist used.

2013-12-18 Thread Shantanu Tushar
Git commit 5b664d5d5d6ca90d2960a43ff5499c7ffe296351 by Shantanu Tushar. Committed on 17/12/2013 at 19:00. Pushed by shantanu into branch 'master'. Revert PMC remembers the last playlist used. This reverts commit 5fdf522c413869d98135494cb2e379d4bf639ded. CCMAIL: plasma-devel@kde.org M +1

Re: Review Request 114634: Make playlist switching code simpler

2013-12-23 Thread Shantanu Tushar
, removing default playlist work fine. Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114741: Add time duration to media item for youtube videos.

2013-12-30 Thread Shantanu Tushar
code there (which converts video duration to hh:mm:ss format) - Shantanu Tushar On Dec. 30, 2013, 6:13 p.m., Sudhendu Kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114741

Re: Review Request 114892: Plasma-mediacenter plays songs or videos: passed as arguments

2014-01-07 Thread Shantanu Tushar
flag if absolutely necessary. - Shantanu Tushar On Jan. 7, 2014, 8:01 a.m., Sujith Haridasan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114892

Re: Review Request 114892: Plasma-mediacenter plays songs or videos: passed as arguments

2014-01-08 Thread Shantanu Tushar
complicated than it ideally should be, mostly due to multiple playlists being not-so-good. Hope we will fix this for the next release. There is one issue that still remains, post fixing that, this can go in. - Shantanu Tushar On Jan. 8, 2014, 6:09 a.m., Sujith Haridasan wrote

Re: Review Request 114892: Plasma-mediacenter plays songs or videos: passed as arguments

2014-01-08 Thread Shantanu Tushar
On Jan. 7, 2014, 6:20 p.m., Shantanu Tushar wrote: libs/mediacenter/playlistmodel.cpp, lines 306-307 https://git.reviewboard.kde.org/r/114892/diff/1/?file=233345#file233345line306 this path is calculated at two places, one here and one on lines 203-204. Try sharing code between

Re: Review Request 114892: Plasma-mediacenter plays songs or videos: passed as arguments

2014-01-09 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114892/#review47113 --- Ship it! Ship It! - Shantanu Tushar On Jan. 8, 2014, 6:22

Re: Review Request 115162: Launch single instance of plasma-mediacenter

2014-01-21 Thread Shantanu Tushar
() , m_mainWindow(0) shells/newshell/application.cpp https://git.reviewboard.kde.org/r/115162/#comment33932 Pass this as parent so that it can be deleted when the application exits m_mainWindow = new MainWindow(this); - Shantanu Tushar On Jan. 21, 2014, 6:44 a.m., Sujith

Re: Review Request 115162: Launch single instance of plasma-mediacenter

2014-01-21 Thread Shantanu Tushar
On Jan. 21, 2014, 5:58 p.m., Shantanu Tushar wrote: I couldn't try it right now but I have this doubt. If there is already a PMC instance running and open a file from Dolphin, does the file indeed start playing? Sujith Haridasan wrote: What I meant to say is if PMC is already

Re: Review Request 115324: Remove extra include from taglib to allow older versions of taglib to be used.

2014-01-26 Thread Shantanu Tushar
analyzer that can find out unused includes* - Shantanu Tushar On Jan. 27, 2014, 4:27 a.m., Matthew John Dawson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115324

Re: Review Request 115447: Add songs or videos to Misc playlist while pmc is running.

2014-02-05 Thread Shantanu Tushar
. However on a personal note, I am very scared of the complexity we are bringing with this as well as the complexity we have from review #114892. Hope we can get rid of all this and do these in a much cleaner way some day. - Shantanu Tushar On Feb. 3, 2014, 3:53 p.m., Sujith Haridasan wrote

[plasma-mediacenter] shells/newshell: Merge branch 'shantanu-sinny-media-caching'

2014-02-16 Thread Shantanu Tushar
Git commit b574f17b803d4c355b6f354dde0634026d536cd4 by Shantanu Tushar. Committed on 16/02/2014 at 12:41. Pushed by shantanu into branch 'master'. Merge branch 'shantanu-sinny-media-caching' This implements a media cache for PMC which is populated by one or more media sources. The media sources

Re: Review Request 115764: Make playlist model aware of currently playing media

2014-02-26 Thread Shantanu Tushar
and with passing multiple files as command line parameters. Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116063: Implementation of the backspace key as an option to go back to the previous window.

2014-02-26 Thread Shantanu Tushar
. Works fine, this can go in :) - Shantanu Tushar On Feb. 26, 2014, 7:45 a.m., Harshit Agarwal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116063

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Shantanu Tushar
.) - Shantanu Tushar On March 1, 2014, 7:11 a.m., Rukshan Chathuranga wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Shantanu Tushar
On March 1, 2014, 7:16 a.m., Shantanu Tushar wrote: Your diff contains commented out changes to metadataupdater.cpp which I think you don't need. Please revert changes to that file and post a fresh diff. (Also, you even copied (END) which mostly happened while copy-pasting from

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Shantanu Tushar
/Kdelibs_Coding_Style - Shantanu Tushar On March 1, 2014, 11:32 a.m., Rukshan Chathuranga wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Shantanu Tushar
if you can figure it out :) - Shantanu Tushar On March 1, 2014, 12:42 p.m., Rukshan Chathuranga wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517

Re: Review Request 114429: use of time data engine - less code

2014-03-01 Thread Shantanu Tushar
only). Please feel free to push with that change. - Shantanu Tushar On Feb. 11, 2014, 12:01 p.m., Heena Mahour wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114429

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-02 Thread Shantanu Tushar
{ ToolButton { } }). This way you will get both the interactions (click and scroll) and will still feel natural. - Shantanu Tushar On March 1, 2014, 3:03 p.m., Rukshan Chathuranga wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-02 Thread Shantanu Tushar
On March 2, 2014, 11:16 a.m., Shantanu Tushar wrote: Good thinking, and in fact this is the idea that first came to my mind. But, as you would've noticed, the experience on clicking the button isn't very natural now because you aren't really pressing the button. Another (and better

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-03 Thread Shantanu Tushar
://git.reviewboard.kde.org/r/116517/#comment36847 why are you doing it like this now? This previous code was better- onReleased: volumeButton.checked = !volumeButton.checked - Shantanu Tushar On March 3, 2014, 3:03 p.m., Rukshan Chathuranga wrote

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-03 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51801 --- Ship it! Ship It! - Shantanu Tushar On March 3, 2014, 3

Re: Review Request 116597: Remove unneeded signal from the plasma mediacenter picasa backend

2014-03-04 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116597/#review51903 --- Ship it! Ship It! - Shantanu Tushar On March 4, 2014, 4

Re: Review Request 116596: Fix for Bug 329168 - It is impossible to remove a media from playlist without playing it first

2014-03-04 Thread Shantanu Tushar
behavior. However, if you move your mouse pointer to items near the end of the view, it starts to scroll like crazy. You might want to look at Playlist.qml line 130 and see if you can make this better. - Shantanu Tushar On March 4, 2014, 3:17 p.m., Ashish Madeti wrote

Re: Review Request 116596: Fix for Bug 329168 - It is impossible to remove a media from playlist without playing it first

2014-03-04 Thread Shantanu Tushar
://git.reviewboard.kde.org/r/116596/#comment36947 I suggest using ListView.Contain instead. - Shantanu Tushar On March 4, 2014, 7:28 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-05 Thread Shantanu Tushar
of showing the controller, because the controller is useless when nothing is playing. See if it works good if you simply show the playlist. - Shantanu Tushar On March 5, 2014, 7:38 p.m., Ashish Madeti wrote: --- This is an automatically

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Shantanu Tushar
a blank screen with Loading spinner. Expected is the homescreen to come back. - Shantanu Tushar On March 6, 2014, 5:20 a.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Shantanu Tushar
On March 6, 2014, 8:01 a.m., Shantanu Tushar wrote: After going to playlist like this, if you press back you get a blank screen with Loading spinner. Expected is the homescreen to come back. Ashish Madeti wrote: 1.Start PMC 2.Click on empty area (playlist shows) 3.Click

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Shantanu Tushar
://git.reviewboard.kde.org/r/116620/#comment37032 You can do it like this- pmcPageStack.pushAndFocus(mediaPlayerInstance ? getMediaPlayer() : getPlaylist()) and then you won't even need braces in onEmptyAreaClicked - Shantanu Tushar On March 6, 2014, 5:20 a.m., Ashish Madeti

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Shantanu Tushar
On March 6, 2014, 8:01 a.m., Shantanu Tushar wrote: After going to playlist like this, if you press back you get a blank screen with Loading spinner. Expected is the homescreen to come back. Ashish Madeti wrote: 1.Start PMC 2.Click on empty area (playlist shows) 3.Click

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/#review52285 --- Ship it! Ship It! - Shantanu Tushar On March 6, 2014, 4

Re: Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering

2014-03-07 Thread Shantanu Tushar
as active. - Shantanu Tushar On March 7, 2014, 9:12 a.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116640

Re: Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering

2014-03-07 Thread Shantanu Tushar
On March 7, 2014, 12:15 p.m., Shantanu Tushar wrote: Cool, reordering now shows the correct media as active. Oops, please ignore this, I completely forgot to take a look at the diff itself (blame the hurry of leaving office on a friday evening :P). Will review the code asap. - Shantanu

Re: Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering

2014-03-07 Thread Shantanu Tushar
this to else if { libs/mediacenter/playlistmodel.cpp https://git.reviewboard.kde.org/r/116640/#comment37064 again, else if { - Shantanu Tushar On March 7, 2014, 1:50 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail

Re: Review Request 116656: Fix for Bug 331820 - Deleting items when searching removes the wrong items

2014-03-08 Thread Shantanu Tushar
/annotate/mediaelements/playlist/Playlist.qml#L106 - Shantanu Tushar On March 8, 2014, 9:24 a.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656

Re: Review Request 116656: Fix for Bug 331820 - Deleting items when searching removes the wrong items

2014-03-08 Thread Shantanu Tushar
/annotate/mediaelements/playlist/Playlist.qml#L106 - Shantanu Tushar On March 8, 2014, 9:24 a.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656

Re: Review Request 116656: Fix for Bug 331820 - Deleting items when searching removes the wrong items

2014-03-08 Thread Shantanu Tushar
indexInSourceModelOf and then deleteing it in QML, I'd suggest you handle the deletion in the model itself. The rationale behind this is that QML is supposed to only contain UI logic. - Shantanu Tushar On March 8, 2014, 7:34 p.m., Ashish Madeti wrote

Re: Review Request 116656: Fix for Bug 331820 - Deleting items when searching removes the wrong items

2014-03-09 Thread Shantanu Tushar
here- mediaelements/playlist/Playlist.qml https://git.reviewboard.kde.org/r/116656/#comment37095 Extra indentation is there, format it. - Shantanu Tushar On March 9, 2014, 5:20 a.m., Ashish Madeti wrote: --- This is an automatically

Re: Review Request 116656: Fix for Bug 331820 - Deleting items when searching removes the wrong items

2014-03-09 Thread Shantanu Tushar
. - Shantanu Tushar On March 9, 2014, 2:33 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

2014-03-09 Thread Shantanu Tushar
. For this you should create a new bug so that someone can fix it). - Shantanu Tushar On March 2, 2014, 10:53 p.m., Harshit Agarwal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554

Re: Review Request 116674: Fix for Bug 331888 - Playing media when searching, often plays the wrong media

2014-03-09 Thread Shantanu Tushar
a bit confusing from the UI bits as if you click a song in the filtered list, the filter gets reset (expected), but the currently playing song is nowhere in the view, you'll have to scroll and manually find it. It will be nice if you can make it automatic as part of this. - Shantanu Tushar

Re: Review Request 116674: Fix for Bug 331888 - Playing media when searching, often plays the wrong media

2014-03-10 Thread Shantanu Tushar
the currentIndex properly of the model and whenever that changes, just positionViewAtIndex to Center on it. - Shantanu Tushar On March 9, 2014, 6:19 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 116674: Fix for Bug 331888 - Playing media when searching, often plays the wrong media

2014-03-10 Thread Shantanu Tushar
without filtering, the view scrolls without any reason. - Shantanu Tushar On March 10, 2014, 3:51 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116674

Re: Review Request 116731: Bug Fix for Music Stats Labels (Bug 331882)

2014-03-11 Thread Shantanu Tushar
of these labels So, I personally won't want this to go in. However, if you think this makes sense, you can wait for what others have to say. - Shantanu Tushar On March 11, 2014, 5:21 p.m., Atul Dubey wrote: --- This is an automatically generated

Re: Review Request 116736: Bug Fixed - The plasma-media center displays the time in AM between 12 noon and 1pm

2014-03-12 Thread Shantanu Tushar
pending to be committed. It has not been commited and the bug fixed. Please submit this review request as discarded. https://git.reviewboard.kde.org/r/114429 - Shantanu Tushar On March 11, 2014, 7:14 p.m., Atul Dubey wrote

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

2014-03-12 Thread Shantanu Tushar
On March 9, 2014, 4:55 p.m., Shantanu Tushar wrote: Not having the playlist already loaded has caused us enough issues in the past. I suggest we start loading the playlist unconditionally. For this, just make a call to getPlaylist() in the init() function in mediacenter.qml Once

Re: Review Request 116744: Play All Button in Plasma Media Center

2014-03-15 Thread Shantanu Tushar
adding the new items. - Shantanu Tushar On March 15, 2014, 5:20 a.m., Atul Dubey wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116744

Re: Review Request 116802: Fix for Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'

2014-03-15 Thread Shantanu Tushar
e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116802/ --- (Updated March 14, 2014, 6:01 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 331919 http://bugs.kde.org

Re: Review Request 116802: Fix for Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'

2014-03-15 Thread Shantanu Tushar
://git.reviewboard.kde.org/r/116802/#comment37291 This should not be needed, afaik - Shantanu Tushar On March 15, 2014, 3:50 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 116802: Fix for Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'

2014-03-15 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116802/#review52998 --- Ship it! Ship It! - Shantanu Tushar On March 15, 2014, 4

Re: Review Request 116824: Implementation of Single time addition on multiple clicks of the Play All button

2014-03-15 Thread Shantanu Tushar
://git.reviewboard.kde.org/r/116824/#comment37293 Where is model1 set? I don't see it being assigned any value ever. - Shantanu Tushar On March 15, 2014, 6:58 p.m., Harshit Agarwal wrote: --- This is an automatically generated e-mail

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

2014-03-15 Thread Shantanu Tushar
https://git.reviewboard.kde.org/r/116554/#comment37295 0 won't work when there are already some itmes in the playlist before addAllSongsToPlaylist is called. - Shantanu Tushar On March 15, 2014, 6:21 p.m., Harshit Agarwal wrote

Re: Review Request 116824: Implementation of Single time addition on multiple clicks of the Play All button

2014-03-15 Thread Shantanu Tushar
On March 15, 2014, 7:43 p.m., Shantanu Tushar wrote: In general I don't see why N clicks of a button won't repeat the action N times, sounds very logical to me. So not sure if it needs fixing. Harshit Agarwal wrote: Agreed, but PlayAll should be a single click feature right

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

2014-03-16 Thread Shantanu Tushar
On March 15, 2014, 7:44 p.m., Shantanu Tushar wrote: browsingbackends/localfiles/localfilesabstractbackend.cpp, line 169 https://git.reviewboard.kde.org/r/116554/diff/2/?file=254194#file254194line169 0 won't work when there are already some itmes in the playlist before

  1   2   3   4   5   >