D13012: Activity switcher auto-hide when using Meta-Tab

thsurrel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY Commit 174aa217180434ab93b899d9c7cf967bd2daff7e

D13042: Do not show activity switcher during fast switches

thsurrel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY When using the keyboard global shortcut to switch quickly between two activities, it does not

D13030: Display brightness OSD even when min and max is reached

thsurrel updated this revision to Diff 34751. thsurrel retitled this revision from "Always display brightness OSD even when at maximum" to "Display brightness OSD even when min and max is reached". thsurrel edited the summary of this revision. thsurrel added a comment. This revision is now

D13042: Do not show activity switcher during fast switches

thsurrel planned changes to this revision. thsurrel added a comment. Good point. I had a look, the timeout is set at 90ms by default. But it is configurable (DelayTime), should I try to read the kwin configuration value or can we just go with 90ms ? REPOSITORY R119 Plasma Desktop

D13042: Do not show activity switcher during fast switches

thsurrel updated this revision to Diff 34774. thsurrel added a comment. Update the timing to match what is used in KWin and Alt-Tab REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13042?vs=34655=34774 REVISION DETAIL

[Powerdevil] [Bug 362830] Allow lowest brightness when using the brightness down/up buttons

https://bugs.kde.org/show_bug.cgi?id=362830 --- Comment #7 from Thomas Surrel <thomas.sur...@protonmail.com> --- Proposed patch: https://phabricator.kde.org/D13095 If you can, try it out and tell me what you think. -- You are receiving this mail because: You are the assignee for the bug.

D13095: Scren brightness follow a quatratic progression

thsurrel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY Modern hardware allow to adjust the screen brightness very precisely, with more than hundreds

D13095: Scren brightness follow a quatratic progression

thsurrel updated this revision to Diff 34825. thsurrel added a reviewer: Plasma. thsurrel added a comment. Added context REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13095?vs=34812=34825 REVISION DETAIL https://phabricator.kde.org/D13095 AFFECTED

D13030: Always display brightness OSD even when at maximum

thsurrel planned changes to this revision. thsurrel marked an inline comment as done. thsurrel added a comment. I think we should do the same thing for the other side of the spectrum: when hitting the minimum value, we should still show the OSD as well. On my laptop, the screen turns

D13030: Always display brightness OSD even when at maximum

thsurrel updated this revision to Diff 34624. REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13030?vs=34622=34624 REVISION DETAIL https://phabricator.kde.org/D13030 AFFECTED FILES daemon/powerdevilbrightnesslogic.cpp To: thsurrel Cc: broulik,

D13030: Always display brightness OSD even when at maximum

thsurrel marked an inline comment as done. thsurrel added inline comments. INLINE COMMENTS > broulik wrote in powerdevilupowerbackend.cpp:406 > Can we be sure that the `currentBrightness` is always up-to-date? We must > still be able to force a new brightness if the hardware forgot to tell us

D13030: Always display brightness OSD even when at maximum

thsurrel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY When the brightness is already at the maximum value, hitting the keyboard shortcut to increase

[Powerdevil] [Bug 362830] Allow lowest brightness when using the brightness down/up buttons

https://bugs.kde.org/show_bug.cgi?id=362830 Thomas Surrel <thomas.sur...@protonmail.com> changed: What|Removed |Added CC||thom

D13095: Scren brightness follow a quatratic progression

thsurrel added a comment. > Same values as `/sys/class/backlight/*/brightness`, in other words. Thanks Nate, even if that's not the answer I was hoping for ... The future of this patch: - accept to break some systems (but who wants that ?) - add an option for this quadratic

D13095: Scren brightness follow a quatratic progression

thsurrel added a comment. Hi Nate, sorry I'm asking you one more thing before giving up on this patch (even though I find it really useful for my personal use). When your screen is off, with a brightness value of 4 for example, could you tell me what is the value reported in

D13095: Scren brightness follow a quatratic progression

thsurrel added a comment. Hi Scott, thanks for the help! If you can apply the patch, we could see if you have the same behavior than Nate with his hardware: when setting a very low value (for him, it's in the range 1 to 5) to /sys/class/backlight//brightness his screen does not turn on at

D13095: Scren brightness follow a quatratic progression

thsurrel added a comment. Could you provide the value of the system brightness after each key press (cat /sys/class/backlight/*/brightness) as well as the maximun brightness of your hardware (cat /sys/class/backlight/*/max_brightness) ? I know, I'm asking you to work with a black screen

D13095: Scren brightness follow a quatratic progression

thsurrel added a comment. Thanks Nate. If your screen does not turn on while passing from 0 to 2, than this patch is in trouble ... Could you tell me at what value your screen does turn on for the first time, starting from 0 (by writing values directly in /sys/class/backlight//brightness)

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel added a comment. Having a second look, this bug is related: https://bugs.kde.org/show_bug.cgi?id=359310 As it is, my patch does not fix that though, so far it remembers the selected item but not the scroll position. I will try to improve my patch to fix both issues. REPOSITORY

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel updated this revision to Diff 42624. thsurrel added a comment. [Folder View] Restore scrolling position when going back BUG: 359310 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15840?vs=42568=42624 BRANCH arc_folderview3 (branched

D16045: [Device Notifier] Auto-hide popup after device is unmounted

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY When unmounting a removable device from dolphin, the device notifier will popup

D16045: [Device Notifier] Auto-hide popup after device is unmounted

thsurrel updated this revision to Diff 43133. thsurrel added a comment. Fix as per broulik comments. Thanks! REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16045?vs=43129=43133 BRANCH arc_autohide (branched from master) REVISION DETAIL

D16045: [Device Notifier] Auto-hide popup after device is unmounted

This revision was automatically updated to reflect the committed changes. Closed by commit R120:581889351e09: [Device Notifier] Auto-hide popup after device is unmounted (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16170: [Device Notifier] Restore busy indicator

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY This patch fixes two issues: - the 'state' of the device now propagates correctly,

D16170: [Device Notifier] Restore busy indicator

thsurrel added a comment. The bad news with this patch is that I don't understand it fully. Why were we doing polling before ? Why was it breaking the 'state' propagation ? What does it change not to do it anymore (performance hit ? something else ?) ? REPOSITORY R120 Plasma Workspace

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel added a comment. F6330071: screenshot2.png F6330070: screenshot1.png Visually, I find it better with the label: two similar icons do not end up in the same area. REPOSITORY R120 Plasma

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY When at least one removable device is mounted, a button shows up that will allow to

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel added a comment. What wording do you think would fit ? It seems quite some effort has been put in avoiding the work "mount". I am also a bit scared of the size the button would take in some languages and if it could collide with "Storage Volume". But maybe it should be somewhere

D16219: [Lock Screen] Do not try to unlock when unvisible

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY In the lock screen, pressing the enter key while the UI is not yet visible ends up

D16219: [Lock Screen] Do not try to unlock when unvisible

thsurrel added a comment. In D16219#343399 , @filipf wrote: > The new lock screen runs the risk of adding extra steps for the user. This is one change that can help the issue because IIRC in Windows you also have a double lock screen and

D16219: [Lock Screen] Do not try to unlock when unvisible

thsurrel added a comment. The bug is https://bugs.kde.org/show_bug.cgi?id=395671 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16219 To: thsurrel, #plasma, #vdg Cc: davidedmundson, abetts, filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D16241: [Folder View] Improve layout and formatting of Icons page

thsurrel added a comment. That looks much better! Any reason why the "Text lines" parameter in the Icon panel is not aligned with the rest of the form ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16241 To: ngraham, #plasma, #vdg, hein Cc: thsurrel,

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel updated this revision to Diff 43929. thsurrel added a comment. Add a text label to the new button Fixes to hide the button correctly when devices unmount REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16212?vs=43624=43929 BRANCH

D16219: [Lock Screen] Do not try to unlock when unvisible

This revision was automatically updated to reflect the committed changes. Closed by commit R120:754efdedd4ee: [Lock Screen] Do not try to unlock when unvisible (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16219: [Lock Screen] Do not try to unlock when unvisible

thsurrel updated this revision to Diff 43792. thsurrel added a comment. Do not access parent property directly Thanks for the comment davidedmundson REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16219?vs=43644=43792 BRANCH arc_enterpressed

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. So, it seems that pulseaudio can not tell the difference what we are plugging in the jack connector on a laptop, but I guess it must be the same behavior with computers that get a sink change when switching from internal speaker to external ? REPOSITORY R115

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. In D16082#356109 , @drosca wrote: > What do you mean with "sink change"? Do you mean that plugging in something in jack will trigger adding new sink (device) to Pulseaudio? That will only be the case for USB

D16170: [Device Notifier] Restore busy indicator

thsurrel added a comment. It is awaiting a review. As I said in an older comment, I don't know if there are some drawbacks to not do polling, but i have been using this patch for a while and it works well. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D16914: [Runners KCM] Focus the search field by default

thsurrel created this revision. thsurrel added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. TEST PLAN Start krunner, click on the parameter button on the left. In the window opening, the plugin search

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. I should be able to test that tonight. But what happens today on a computer that does a _sink change_ (and not a port change like on my computer) when plugging in speakers in a laptop jack connector ? Can it tell it is not headphones ? Anybody could try that ?

D16082: Notify headphone being plugged in on some hardware

thsurrel marked 5 inline comments as done. thsurrel added a comment. Ping ! Anybody else managed to test this ? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D16082 To: thsurrel, #plasma, #vdg, drosca Cc: broulik, nicolasfella, plasma-devel,

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. Having a visual feedback would be useful when pairing bluetooth speakers IMO (does it ? I don't have any to test with). For a jack connection, that is indeed less useful, but that would be consistent. In addition, the plasma-pa has an option to turn the OSD

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. Absolutely, as said in my previous comment, I agree the usefulness of the OSD in that case is very much questionable. I was raising questions on a different level: - would it be import to be consistent and show an OSD in the jack case if we are showing one in

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. The speaker icon could maybe get a newer version that would be different than the one used to show the volume level ? It does also look a bit unpolished compared to the headphone one. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. Should I do anything special about this Diff ? Do we just keep it as it is for reference ? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D16082 To: thsurrel, #plasma, #vdg, drosca, ngraham Cc: ngraham, broulik,

D15877: [KonsoleProfiles applet] Fix navigating with the keyboard

This revision was automatically updated to reflect the committed changes. Closed by commit R114:943122b4429d: [KonsoleProfiles applet] Fix navigating with the keyboard (authored by thsurrel). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

This revision was automatically updated to reflect the committed changes. Closed by commit R119:df458e9ea505: [Folder View] In list view mode, fix home button disappearing every other… (authored by thsurrel). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D15963: [KonsoleProfiles applet] Fix initial focus

thsurrel created this revision. thsurrel added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY Now arrow key nav works when opening a panel applet via keyboard shortcut.

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel updated this revision to Diff 43266. thsurrel added a comment. I'm not sure how I managed to lose this bit when preparing this. Thanks for your patience, hein, I have been doing a pretty poor job on this patch. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D16053: Fix initial focus

thsurrel created this revision. thsurrel added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY Now arrow key nav works when opening a panel applet via keyboard shortcut. Fixes the same

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel updated this revision to Diff 43190. thsurrel added a comment. Use gridView.visibleArea REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15840?vs=43158=43190 BRANCH arc_folderview3 (branched from master) REVISION DETAIL

D16082: Notify headphone being plugged in on some hardware

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY On my computer, plugging the headphones in and out does not create a sink change but

D16082: Notify headphone being plugged in on some hardware

thsurrel updated this revision to Diff 43271. thsurrel added a comment. Fixes as per broulik comments. Thanks for the review! REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16082?vs=43237=43271 BRANCH arc_ports (branched from

D15840: [Folder View] Remember selected item when navigating in subfolders

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6736bdaa4bbd: [Folder View] Remember selected item when navigating in subfolders (authored by thsurrel). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

thsurrel added a comment. I don't have a developer account, can you be the pilot for landing this ? Thanks in advance. REPOSITORY R119 Plasma Desktop BRANCH arc_folderview (branched from master) REVISION DETAIL https://phabricator.kde.org/D15823 To: thsurrel, #plasma, #vdg, hein Cc:

D15877: [KonsoleProfiles applet] Fix navigating with the keyboard

thsurrel added a comment. I don't have a developer account, could you land this ? Thanks REPOSITORY R114 Plasma Addons BRANCH arc_konsoleprofiles (branched from master) REVISION DETAIL https://phabricator.kde.org/D15877 To: thsurrel, #plasma, davidedmundson Cc: plasma-devel, ragreen,

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

thsurrel added a comment. F6299154: screenshot.png Showing the missing home button in the top left corner. The button would appear again if I would navigate one folder up or down. REPOSITORY R119 Plasma Desktop BRANCH arc_folderview (branched

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH arc_folderview (branched from master) REVISION DETAIL

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

thsurrel updated this revision to Diff 42527. thsurrel added a comment. Sorry, this second commit ended up in the same arc diff, this is not what I intended. I'm still learning... REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D15824: [Folder View] Fix right/left arrow navigation in popup + list view mode

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH arc_folderview2 (branched from master) REVISION DETAIL

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

thsurrel updated this revision to Diff 42526. thsurrel added a comment. [Folder View] Fix right/left arrow navigation in popup + list view mode REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15823?vs=42524=42526 BRANCH arc_folderview (branched

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel created this revision. thsurrel added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY When using the folder view in a panel as a popup, being in list view mode, getting into

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel added inline comments. INLINE COMMENTS > anthonyfieroni wrote in FolderView.qml:1114 > Do we have grodView.model after back clicked? If we do in expanded view > (that's when Folder View is embedded in the panel) goingBack will not be > performed. My understanding was that the

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel added inline comments. INLINE COMMENTS > anthonyfieroni wrote in FolderView.qml:1114 > Ok, then just embed Folder View in the panel (by right click on the panel, > panel options -> add widgets or drag'n'drop it in) then navigate to check > that should it goback to be applied as well.

D15877: [KonsoleProfiles applet] Fix navigating with the keyboard

thsurrel created this revision. thsurrel added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY BUG: 399192 TEST PLAN Create several profiles in Konsole. Open the Konsole Profiles

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel updated this revision to Diff 42966. thsurrel added a comment. Pop all history info at once when navigating back REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15840?vs=42624=42966 BRANCH arc_folderview3 (branched from master) REVISION

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel added a comment. In D15840#337446 , @hein wrote: > I like the goal here, but it's not a given the stored index is still valid when navigating back - the folder contents could have changed. It'd be hygienic to bound the access when

D15824: [Folder View] Fix right/left arrow navigation in popup mode

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0337f979189c: [Folder View] Fix right/left arrow navigation in popup mode (authored by thsurrel). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel updated this revision to Diff 43158. thsurrel added a comment. Limit index and position to the current gridview state, in case some elements have disappeared since we visited the parent folder. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D17874: [dimdisplay] Effectively waits display to wake-up

thsurrel added a comment. Sorry I did not have any time to test this, but I am really interested to see the result. I am back from my holidays now, I should be able to test tomorrow. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D17874 To: anthonyfieroni, mart,

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel added inline comments. INLINE COMMENTS > broulik wrote in devicenotifier.qml:122 > This is for having the bindings refresh, right? Yes indeed. Any better ways ? REPOSITORY R120 Plasma Workspace BRANCH arc_unmountall (branched from master) REVISION DETAIL

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel marked 6 inline comments as done. thsurrel added inline comments. INLINE COMMENTS > broulik wrote in DeviceItem.qml:92 > Can we assume "action" is always unmount? If the device is removable and mounted, than the action can only be unmounting, yes. > broulik wrote in

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel added inline comments. INLINE COMMENTS > broulik wrote in FullRepresentation.qml:113 > How about adding the following to the button: > > Layout.alignment: Qt.AlignRight > Layout.preferredWidth: minimumWidth That does not seem to do the trick. I am trying to have the button at a

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel updated this revision to Diff 49640. thsurrel added a comment. Trying to improve based on broulik comments. Thank you very much for the review! REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16212?vs=46999=49640 BRANCH arc_unmountall

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel added a comment. There is a regression, I did not notice at first. By storing the connectedRemovables and not the mountedRemovables, the unmountAll button will appear even if nothing is mounted. That's not good. I have to update a list in the onMountedChanged slot as I was doing

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel updated this revision to Diff 49644. thsurrel added a comment. Display the unmountAll button only when there are some MOUNTED devices. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16212?vs=49640=49644 BRANCH arc_unmountall (branched

D18438: [Task Manager] When closing apps, resize only when mouse is out.

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY When closing several apps from the task manager with the mouse middle button, it is

D16212: [Device Notifier] Add a button to unmount all devices

This revision was automatically updated to reflect the committed changes. Closed by commit R120:81db74434cd5: [Device Notifier] Add a button to unmount all devices (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel added a comment. A last minute review in case this can get into 5.15 ? Please :) REPOSITORY R120 Plasma Workspace BRANCH arc_unmountall (branched from master) REVISION DETAIL https://phabricator.kde.org/D16212 To: thsurrel, #plasma, #vdg, ngraham Cc: broulik, ngraham,

D17394: [Device Notifier] Fix transition animation

thsurrel added inline comments. INLINE COMMENTS > davidedmundson wrote in DeviceItem.qml:197 > alwaysRunToEnd : true That does not work by itself. REPOSITORY R120 Plasma Workspace BRANCH arc_transitions (branched from master) REVISION DETAIL https://phabricator.kde.org/D17394 To:

D17402: [Device Notifier] Disable the possibility to unmount the root partition

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH arc_unmountroot (branched from master) REVISION DETAIL

D17394: [Device Notifier] Fix transition animation

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ab47422c1b41: [Device Notifier] Fix transition animation (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17394?vs=47001=47023

D17394: [Device Notifier] Fix transition animation

thsurrel added a comment. In D17394#372523 , @broulik wrote: > Is this Bug 379759? I don't think so, but I will have a look at that one too. If any of you guys can have a look at my other device notifier patches, that would be

D17401: [Device Automounter KCM] Improve the tree view header spacing

thsurrel created this revision. thsurrel added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH arc_automounter_kcm (branched from master) REVISION DETAIL

D17402: [Device Notifier] Disable the possibility to unmount the root partition

thsurrel added a comment. Can you develop why ? Is because of the added code ? From a usability point of view, does it not make sense to disable something that is not possible ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17402 To: thsurrel, #plasma,

D17401: [Device Automounter KCM] Improve the tree view header spacing

This revision was automatically updated to reflect the committed changes. Closed by commit R119:66e05cb9c097: [Device Automounter KCM] Improve the tree view header spacing (authored by thsurrel). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D17402: [Device Notifier] Disable the possibility to unmount the root partition

thsurrel added a comment. You need to configure the plasmoid and select to show "All devices". It's showing removable devices only by default (which sounds pretty sane!). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17402 To: thsurrel, #plasma, #vdg Cc:

D17420: [Device Notifier] Fix action button vertical alignment

thsurrel created this revision. thsurrel added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH arc_alignment (branched from master) REVISION DETAIL

D17402: [Device Notifier] Disable the possibility to unmount the root partition

thsurrel added a comment. I made another patch that fixes the alignment D17420 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17402 To: thsurrel, #plasma, #vdg Cc: abetts, ngraham, broulik, plasma-devel, ragreen,

D17420: [Device Notifier] Fix action button vertical alignment

thsurrel updated this revision to Diff 47080. thsurrel added a comment. No more magic :( REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17420?vs=47079=47080 BRANCH arc_alignment (branched from master) REVISION DETAIL

D17420: [Device Notifier] Fix action button vertical alignment

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2c541ac87c4d: [Device Notifier] Fix action button vertical alignment (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel updated this revision to Diff 46939. thsurrel added a comment. Fix button width REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16212?vs=43929=46939 BRANCH arc_unmountall (branched from master) REVISION DETAIL

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel marked 2 inline comments as done. thsurrel added inline comments. INLINE COMMENTS > ngraham wrote in devicenotifier.qml:51 > mountedRemouvables -> mountedRemovables (and change all other instances, > obviously) I put too much French into this one ;) REPOSITORY R120 Plasma Workspace

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel updated this revision to Diff 46999. thsurrel added a comment. Improvements as per Nate's comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16212?vs=46939=46999 BRANCH arc_unmountall (branched from master) REVISION DETAIL

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel marked an inline comment as done. thsurrel added inline comments. INLINE COMMENTS > ngraham wrote in devicenotifier.qml:51 > En Anglais, les mots n'utilisent pas la lettre «u» aussi souvent qu'en > Français. :) Je ne savais pas que tu parlais français !  REPOSITORY R120 Plasma

D17394: [Device Notifier] Fix transition animation

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY In the specific case of having the device notifier opened and inserting a device that

D16918: [dimdisplay] Do not change screen brightness on invalid values

thsurrel added a comment. This bug is bothering me too and I haven't found a fix either. I use an external screen connected to my laptop and I turn my laptop screen off by setting its brightness to 0. Then whenever I go away for a moment and the screen is turned off because energy saving

D16918: [dimdisplay] Do not change screen brightness on invalid values

thsurrel added a comment. Neither helped... The problem may not be in plasma. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D16918 To: anthonyfieroni, #plasma, broulik, mart Cc: thsurrel, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17203: [Task Manager] Move apps to activities from the context menu

thsurrel added a comment. Yes, indeed. But it is just a proposal. This patch mimics what is done for desktops: you can move a window to a desktop or to all of them. You lose the ability to add a window to an activity, but do we have a strong use case for that ? I personally always want to

D17203: [Task Manager] Move apps to activities from the context menu

thsurrel abandoned this revision. thsurrel added a comment. I use it differently then ! :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17203 To: thsurrel, #plasma, hein Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

  1   2   >