tcberner added inline comments.
INLINE COMMENTS
> bshah wrote in main_wayland.cpp:424-426
> This also need adaption for HAVE_PROC_TRACE_CTL perhaps? @tcberner can help
> us here maybe.
Sure, I will create a request as soon as I have some time to add it.
Btw, couldn't this be added as some
tcberner marked 4 inline comments as done.
tcberner added a comment.
Mark stuff done.
REPOSITORY
rKSCREENLOCKER KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D1216
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: tcberner, rakuco,
This revision was automatically updated to reflect the committed changes.
Closed by commit rKSCREENLOCKER42ad07d79785: Disallow ptrace on greeter and
kcheckpass process on FreeBSD (authored by tcberner).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D1216?vs=3009=3032#toc
REPOSITORY
tcberner created this revision.
tcberner added reviewers: graesslin, rakuco.
tcberner set the repository for this revision to rKSCREENLOCKER KScreenLocker.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
REVISION SUMMARY
Use FreeBSDs `procctl` to disable gdb from
tcberner abandoned this revision.
tcberner added a comment.
This issue seems to be fixed with the `resizePanel()` you mentioned that has
appeared in `12f7cbf5`.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1616
EMAIL PREFERENCES
tcberner created this revision.
tcberner added a reviewer: drosca.
tcberner set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The function
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN2ea5feb35b67: Disallow ptrace on greeter and kwin_wayland
process on FreeBSD [... for the… (authored by tcberner).
REPOSITORY
rKWIN KWin
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLAND1d531e997bfc: pid_t is defined in sys/types.h
(authored by tcberner).
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1579?vs=3732=3739
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit rPOLKITKDEAGENT2e7efafe58f9: Disallow ptrace on polkit agent
on FreeBSD (authored by tcberner).
REPOSITORY
rPOLKITKDEAGENT Policykit (Polkit) KDE Agent
CHANGES SINCE LAST UPDATE
tcberner created this revision.
tcberner added reviewers: rakuco, graesslin.
tcberner set the repository for this revision to rPOLKITKDEAGENT Policykit
(Polkit) KDE Agent.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
tcberner created this revision.
tcberner added a reviewer: graesslin.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
To use pid_t one should include sys/types.h -- else the build fails on
FreeBSD.
REPOSITORY
tcberner updated this revision to Diff 3735.
tcberner added a comment.
Regenerate the patch.
REPOSITORY
rKWIN KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1425?vs=3368=3735
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D1425
AFFECTED FILES
tcberner added a comment.
On FreeBSD we have linux/input.h provided by multimedia/v4l_compat [1] --
which we already depend on at the moment.
But I think it's a good idea to make it optional.
[1] https://www.freshports.org/multimedia/v4l_compat
REPOSITORY
rKWAYLAND KWayland
tcberner created this revision.
tcberner added a reviewer: graesslin.
Restricted Application added a subscriber: plasma-devel.
Restricted Application added a project: Plasma on Wayland.
REVISION SUMMARY
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLAND70ba7718eee5: Include to fix build on
FreeBSD (authored by tcberner).
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3289?vs=7952=7953
REVISION DETAIL
as no respin after the announcement, what makes you think there was?
>
> Jonathan
>
>
> On Thu, Mar 23, 2017 at 08:16:42AM +0100, Tobias C. Berner wrote:
> > Hi
> >
> > it seems the tarballs were respun after the announcement. Could you in
> the
> > future
kmi...@kubuntu.org> wrote:
> Re-spun *before* the announcement email @ 14:53 UTC if I recall from IRC.
>
> If you grabbed the tarballs beforehand, then yes you may the have ones
> prior to the respin?
>
> On 23/03/17 07:16, Tobias C. Berner wrote:
> > Hi
> >
> &g
Hi
it seems the tarballs were respun after the announcement. Could you in the
future, please give a little notice of that?
mfg Tobias
On 21 March 2017 at 15:53, Jonathan Riddell wrote:
> Out now
> https://www.kde.org/announcements/plasma-5.9.4.php
>
tcberner created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7174
AFFECTED FILES
metainfo.yaml
To: tcberner, #freebsd, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e10dd47d6d4f: Add FreeBSD to metainfo.yaml (authored by
tcberner).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7174?vs=17802=18539#toc
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
Hi there
I think this review introduced some Linux-only features: signalfd() is
only present on Linux.
So this breaks kcheckpass on FreeBSD (and probably everything non-Linux too).
Would it be possible to have the long-running auth stuff hidden behind a
check_include_file("sys/signalfd.h"
tcberner added a comment.
In https://phabricator.kde.org/D5825#109093, @davidedmundson wrote:
> > but now that it is all here already, let's just call this a prototype,
for someone who knows C/kevent/kqueue to fix.
>
> So what doesn't work?
I have not yet had time to test it
tcberner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
All there in the title.
REPOSITORY
R133 KScreenLocker
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5825
AFFECTED
tcberner edited the summary of this revision.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D5825
To: tcberner, #freebsd, graesslin
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, lukas
tcberner retitled this revision from "Include signal.h for kill." to "Include
signal.h for kill(), and prototype kqueue/kevent stuff... ".
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D5825
To: tcberner, #freebsd, graesslin
Cc: plasma-devel, ZrenBot, spstarr,
on all other *BSD and OSX too.
mfg Tobias
On 12 May 2017 at 15:55, Martin Flöser <mgraess...@kde.org> wrote:
> Am 2017-05-12 09:18, schrieb Tobias C. Berner:
>>
>> Hi there
>>
>> I think this review introduced some Linux-only features: signalfd() is
>> o
tcberner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Use the cmake variable rather than the library name to link.
This fixes linking on FreeBSD, where the library location is not
in the
tcberner added a comment.
I can successfully unlock the lockscreen, with this code .
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D5825
To: tcberner, #freebsd, graesslin
Cc: adridg, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai,
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f0e45cd42ba7: Use ${X11_XTest_LIB} rather than Xtst.
(authored by tcberner).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5997?vs=14905=14909
REVISION
tcberner updated this revision to Diff 14906.
tcberner retitled this revision from "Include signal.h for kill(), and
prototype kqueue/kevent stuff... " to "Include signal.h for kill(), and
prototype kqueue/kevent stuff...".
tcberner added a comment.
Use sigwaitinfo() to get information on
tcberner retitled this revision from "Include signal.h for kill(), and
prototype kqueue/kevent stuff..." to "kcheckpass: Add support in for non-Linux
platforms via kevent.".
tcberner edited the summary of this revision.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:c2fd8526c523: kcheckpass: Add support in for non-Linux
platforms via kevent. (authored by tcberner).
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
tcberner added a comment.
I want to look at this some more this weekend.
INLINE COMMENTS
> adridg wrote in kcheckpass.c:77
> Possibly add
>
> #if !(HAVE_SIGNALFD_H_ || HAVE_EVENT_H)
> #error
> #endif
>
> to double-check that it's one or the other (reflecting the check in CMake)
That
tcberner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This is useful on FreeBSD, where we don't have loginctl.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
tcberner added a reviewer: kde-mac.
tcberner marked 2 inline comments as done.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D5825
To: tcberner, #freebsd, graesslin, kde-mac
Cc: adridg, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai,
tcberner added a subscriber: erichameleers.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D6004
To: tcberner, #freebsd, graesslin, #plasma
Cc: erichameleers, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol,
tcberner added a comment.
> Do you actually intend to test this on Mac?
Nope, I don't have a Mac :) -- but I hoped, that there were some Mac users
who could check it on their end too (as you also have kqueue/kevent) -- but I
did not know that most of the stuff is not yet ported for Mac.
tcberner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Unfortunately I only tested the kevent stuff on FreeBSD 12. FreeBSD < 12 has
an older clang, which seems to add less headers automatically.
tcberner added inline comments.
INLINE COMMENTS
> graesslin wrote in CMakeLists.txt:78
> I would keep this information about the contact. We want to be friendly here
> and it's such a touchy topic that I prefer to be very explicit that we do
> want to support other solutions.
Ok.
> graesslin
tcberner accepted this revision.
tcberner added a comment.
This revision is now accepted and ready to land.
Looks good to me. Sorry for the timeout :)
REPOSITORY
R108 KWin
BRANCH
wayland-realtime
REVISION DETAIL
https://phabricator.kde.org/D7757
To: graesslin, #kwin, #plasma,
tcberner created this revision.
tcberner added reviewers: FreeBSD, mvourlakos.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
- FreeBSD now has a port for this in k...@freebsd.org's development repo.
REPOSITORY
R878
tcberner added a comment.
I could not find anything similar. So that's probably the way to go.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7757
To: graesslin, #kwin, #plasma
Cc: tcberner, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed,
tcberner added a comment.
^
/home/Tobias/git/kwin/main_wayland.cpp:452:38: error: use of undeclared
identifier 'SCHED_RESET_ON_FORK'
sched_setscheduler(0, SCHED_RR | SCHED_RESET_ON_FORK, );
^
Yes,
tcberner updated this revision to Diff 24889.
tcberner edited the summary of this revision.
tcberner added a comment.
Update.
I was not yet able to test it, yet
- switches to qdbus in ck-unlock-session script
- only looks for ConsoleKit if loginctl was not found
tcberner updated this revision to Diff 24892.
tcberner added a comment.
Fix qdbus name.
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6004?vs=24889=24892
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6004
AFFECTED FILES
tcberner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
tcberner requested review of this revision.
REPOSITORY
R133 KScreenLocker
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9713
AFFECTED
tcberner added inline comments.
INLINE COMMENTS
> graesslin wrote in abstractlocker.cpp:53
> I think this needs to be runtime detected.
So something ala
- if logingd-runing then logindmessage
- if consolekit-running then consolekitmessage
- else falback message
REPOSITORY
R133 KScreenLocker
tcberner added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Hi there
This breaks the CI on FreeBSD, where we only have libinput 1.6
10:17:48 -- Could NOT find Libinput: Found unsuitable version "1.6.0", but
required is at least "1.9" (found
tcberner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
tcberner requested review of this revision.
REVISION SUMMARY
- Detect ConsoleLit/logind at runtime (logind untested).
REPOSITORY
R133 KScreenLocker
BRANCH
tcberner abandoned this revision.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D10134
To: tcberner
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
tcberner updated this revision to Diff 26031.
tcberner added a comment.
Use QDbus to query whether ConsoleKit or LoginD is presnet (note, I have not
tested LoginD :) )
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9713?vs=24891=26031
BRANCH
tcberner abandoned this revision.
tcberner added a comment.
Continued in https://phabricator.kde.org/D9713
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D6004
To: tcberner, #freebsd, graesslin, #plasma
Cc: PureTryOut, erichameleers, plasma-devel, ZrenBot,
tcberner added a reviewer: FreeBSD.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D9713
To: tcberner, graesslin, #freebsd
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
tcberner added a reviewer: Plasma.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D9713
To: tcberner, graesslin, #freebsd, #plasma
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
Hi Ben
I think we could upgrade the CI to 5.10 "sans webengine" -- which is the
one part we are missing.
mfg Tobias
On 19 February 2018 at 20:17, Ben Cooksley wrote:
> On 20/02/2018 12:23 AM, "Jonathan Riddell" wrote:
>
> Hi Jonathan,
>
> Plasma 5.13,
tcberner updated this revision to Diff 27901.
tcberner added a comment.
- Switch the url to https://github.com/ConsoleKit2/ConsoleKit2
- coble together something less "unfortunate" from the official description:
//ConsoleKit2 is a framework for defining and tracking users, login sessions,
tcberner updated this revision to Diff 27898.
tcberner added a comment.
- Fix logind1 dbus path
- Improve CMakeLists.txt to only display the feature once
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9713?vs=26031=27898
BRANCH
master
REVISION
tcberner added a comment.
On FreeBSD the configure now looks like:
[...]
-- Could NOT find loginctl (missing: loginctl_EXECUTABLE)
-- Found ConsoleKit: /usr/local/bin/ck-list-sessions
[...]
* prctl/procctl tracing control, Required for disallowing ptrace on
greeter
tcberner added a comment.
We could certainly do that by removing the wrapping `if ( NOT HAVE_LOGINCTL
)`.
Additionally, also the order of the if-branches in `abstractlocker.cpp` would
probably need to be reordered as to prefere login1.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
tcberner added a comment.
Sure. I kind of forgot about it. Sorry.
You can find a more current version at
https://github.com/freebsd/freebsd-ports-kde/tree/kde5.9-import/security/plasma5-kscreenlocker/files
Note, the only needed thing is basically that ck skript. The rest is just
This revision was automatically updated to reflect the committed changes.
tcberner marked an inline comment as done.
Closed by commit R133:68fb0b7d3e1c: Add script to unlock a broken session via
ConsoleKit. (authored by tcberner).
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
tcberner created this revision.
tcberner added reviewers: FreeBSD, mvourlakos.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
tcberner requested review of this revision.
REVISION SUMMARY
latte-dock-0.8.0/app/dock/dockview.h:367:44:
Moin moin
I'm not sure if this is related to the issue I reported here some time ago:
https://bugreports.qt.io/browse/QTBUG-61802
mfg Tobias
On Fri, 3 Aug 2018 at 18:00, Martin Flöser wrote:
> Am 2018-08-03 12:04, schrieb Ben Cooksley:
> > Hi all,
> >
> > Sometime recently there was a change
This revision was automatically updated to reflect the committed changes.
Closed by commit R878:156accc34f44: Fix build on FreeBSD by including
array. (authored by tcberner).
REPOSITORY
R878 Latte Dock
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14534?vs=38897=40710
REVISION
tcberner added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
In https://phabricator.kde.org/D9930#194036, @graesslin wrote:
> In https://phabricator.kde.org/D9930#193993, @tcberner wrote:
>
> > Hi there
> >
> > This breaks the CI on FreeBSD, where
This revision was automatically updated to reflect the committed changes.
Closed by commit R878:36033bac748f: Add FreeBSD port from the development-repo
(authored by tcberner).
REPOSITORY
R878 Latte Dock
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8302?vs=29455=29456
REVISION
tcberner updated this revision to Diff 29455.
tcberner added a comment.
Update text
REPOSITORY
R878 Latte Dock
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8302?vs=20765=29455
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8302
AFFECTED FILES
README.md
To:
This revision was automatically updated to reflect the committed changes.
Closed by commit R123:1c1f654b0010: sddm-kcm: dont hardcode session file
location. (authored by Róbert Bagdán kikadf...@gmail.com, committed by
tcberner).
REPOSITORY
R123 SDDM Configuration Panel (KCM)
CHANGES SINCE
tcberner created this revision.
tcberner added a reviewer: FreeBSD.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcberner requested review of this revision.
REVISION SUMMARY
The sddm-kcm uses /usr/share/xsessions and /usr/share/wayland-sessions
pathes, but in
tcberner created this revision.
tcberner added reviewers: FreeBSD, dfaure, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcberner requested review of this revision.
REVISION SUMMARY
Similar to XDG_DATA_DIRS defaulting to KDE_INSTALL_FULL_DATAROOTDIR, and
some
tcberner updated this revision to Diff 68731.
tcberner added a comment.
Fix comment and commit message.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24810?vs=68379=68731
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D24810
tcberner updated this revision to Diff 68732.
tcberner edited the summary of this revision.
tcberner added a comment.
Update commit message in diff.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24810?vs=68731=68732
BRANCH
master
REVISION
Moin moin
Is there a functional change included, or is it just without the
build-directory?
mfg Tobias
On Thu, 15 Oct 2020 at 23:23, Jonathan Riddell wrote:
>
> There were still problems with the systemsettings tar so I've made a new one
>
> -
tcberner added inline comments.
INLINE COMMENTS
> user.cpp:23
> #include
> +#ifndef Q_OS_FREEBSD
> #include
wouldn't it be a bit more portable to check for the header file in cmake?
(OpenBSD also has the same issue, I would assume from [1])
[1]
Moin moin
I'm a bit concerned about it seeming to be built on a stack of
abandonware -- qtfeedback (no release), and presage (2015).
mfg Tobias
On Fri, 25 Jun 2021 at 16:38, Aleix Pol wrote:
>
> Dear distros,
> It's been pointed out to me that we never formally explained our
> relationship
Moin moin
Was the change in the distfile naming scheme by choice?
The leading 'v' in the version was not present in previous releases.
It's not an issue, it just means more work for packages :)
mfg Tobias
On Mon, 5 Apr 2021 at 20:38, Vlad Zahorodnii wrote:
>
> Hi,
>
> The v1.2.0 release of
Moin moin
Thanks for the heads-up.
Please note that FreeBSD does not have networkmanager, so having it
optional is fine, but making it a required dependency will lead to
issues.
mfg Tobias
On Fri, 16 Sept 2022 at 18:42, Fusion Future wrote:
>
> Hello,
>
> There are 3 additional optional
77 matches
Mail list logo