Review Request: Limit tooltip size for klipper

Testing --- No problem with an acceptable size. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Limit tooltip size for klipper

r/tray.cpp 3f4fc83 Diff: http://git.reviewboard.kde.org/r/106829/diff/ Testing --- No problem with an acceptable size. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Limit tooltip size for klipper

829/#review20286 ------- On Oct. 13, 2012, 4:31 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.or

Re: Review Request: Limit tooltip size for klipper

geometry of the screen it will show up on. > > > > this should probably be put into the notifications UI code instead. > > this way it will be fixed for any user of the notifications and can be set > > for the given screen. > > > > good catch

Review Request: Change Battery Percentage step of battery plasmoid

is much better for visual. Diffs - plasma/generic/applets/batterymonitor/contents/ui/BatteryIcon.qml cfb50df Diff: http://git.reviewboard.kde.org/r/107612/diff/ Testing --- No problem. Thanks, Xuetian Weng ___ Plasma-devel mailing list

Re: Review Request: Change Battery Percentage step of battery plasmoid

.kde.org/r/107612/#review23073 --- On Dec. 6, 2012, 2:23 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107612/ >

Re: Review Request: Change Battery Percentage step of battery plasmoid

it.reviewboard.kde.org/r/107612/diff/ Testing ------- No problem. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: show notification summary for last popup notification

http://git.reviewboard.kde.org/r/107743/diff/ Testing --- No problem here. Looks ok. Screenshots --- current appearance http://git.reviewboard.kde.org/r/107743/s/899/ Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request: show notification summary for last popup notification

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107743/#review23571 ------- On Dec. 15, 2012, 9:17 p.m., Xuetian Weng wrote: > > -

Re: Review Request: show notification summary for last popup notification

pearance http://git.reviewboard.kde.org/r/107743/s/899/ Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: show notification summary for last popup notification

here. Looks ok. Screenshots --- current appearance http://git.reviewboard.kde.org/r/107743/s/899/ Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Fix pager window dragging and icon

75 Diffs - plasma/desktop/applets/pager/package/contents/ui/main.qml 40a829d Diff: http://git.reviewboard.kde.org/r/107828/diff/ Testing --- No problem. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://ma

Review Request: add pager drag switch feature back

/pager.cpp 956bde2 Diff: http://git.reviewboard.kde.org/r/107843/diff/ Testing --- tested, no problem. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: add pager drag switch feature back

lasma/desktop/applets/pager/pager.h 767b2dd plasma/desktop/applets/pager/pager.cpp 956bde2 Diff: http://git.reviewboard.kde.org/r/107843/diff/ Testing --- tested, no problem. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kd

Re: Review Request: add pager drag switch feature back

(updated) - plasma/desktop/applets/pager/package/contents/ui/main.qml 9f53b7f plasma/desktop/applets/pager/pager.h 767b2dd plasma/desktop/applets/pager/pager.cpp 956bde2 Diff: http://git.reviewboard.kde.org/r/107843/diff/ Testing --- tested, no problem. Thanks, Xuetian Weng

Re: Review Request: add pager drag switch feature back

(updated) - plasma/desktop/applets/pager/package/contents/ui/main.qml 9f53b7f plasma/desktop/applets/pager/pager.h 767b2dd plasma/desktop/applets/pager/pager.cpp 956bde2 Diff: http://git.reviewboard.kde.org/r/107843/diff/ Testing --- tested, no problem. Thanks, Xuetian Weng

Re: Review Request: show notification summary for last popup notification

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107743/#review23878 --- bump - Xuetian Weng On Dec. 17, 2012, 2:18 a.m., Xuetian

Re: Review Request: show notification summary for last popup notification

shots --- current appearance http://git.reviewboard.kde.org/r/107743/s/899/ Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: show notification summary for last popup notification

e.qml 9e4345a Diff: http://git.reviewboard.kde.org/r/107743/diff/ Testing --- No problem here. Looks ok. Screenshots --- current appearance http://git.reviewboard.kde.org/r/107743/s/899/ Thanks, Xuetian Weng ___ Plasma-devel mailing

Review Request: try fix tooltip shadow problem

ignal, hence it will handle that gracefully. This addresses bug 311502. http://bugs.kde.org/show_bug.cgi?id=311502 Diffs - plasma/tooltipmanager.cpp 00bfcdb Diff: http://git.reviewboard.kde.org/r/107905/diff/ Testing --- seems it fixed, but not sure it's the right way. T

Re: Review Request: try fix tooltip shadow problem

fixed, but not sure it's the right way. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: use Plasma::Dialog for brightness osd

--- well, you know.. this would fix the shadow problem. Diffs - powerdevil/daemon/brightnessosdwidget.h ef08903 powerdevil/daemon/brightnessosdwidget.cpp e4cf80a Diff: http://git.reviewboard.kde.org/r/108222/diff/ Testing --- locally tested, problem. Thanks, Xuetian Weng

Review Request: use Plasma::Dialog for kmix osd

, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: fix kwin tabbox shadow

/brightnessosdwidget.h ef08903 powerdevil/daemon/brightnessosdwidget.cpp e4cf80a Diff: http://git.reviewboard.kde.org/r/108224/diff/ Testing --- compiles, no problem. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request: fix kwin tabbox shadow

this right so I just take a easiest way for this. (And to call attention for right people on this, on purpose :P) - Xuetian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108224/#review

Re: Review Request: use Plasma::Dialog for brightness osd

/diff/ Testing (updated) --- locally tested, no problem. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: use Plasma::Dialog for brightness osd

o see if we don't consider that bug, it will work or not. - Xuetian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/#review24834 ------

Re: Review Request: use Plasma::Dialog for brightness osd

23/ - Xuetian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/#review24840 --- On Jan. 6, 2013, 1:36 p.m., Xue

Re: Review Request: use Plasma::Dialog for brightness osd

: http://git.reviewboard.kde.org/r/108222/diff/ Testing --- locally tested, no problem. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: use Plasma::Dialog for kmix osd

://git.reviewboard.kde.org/r/108223/diff/ Testing --- localily tested, no problem Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: use Plasma::Dialog for kmix osd

/ Testing --- localily tested, no problem Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: use Plasma::Dialog for brightness osd

/diff/ Testing --- locally tested, no problem. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: use Plasma::Dialog for icontasks tooltips

w whether some other API affect it or not), and Plasma::Dialog use WA_X11NetWmWindowTypeToolTip to test whether to use edge hug with panel or not, you won't want that with tooltip. - Xuetian Weng On Jan. 7, 2013, 1:53 p.m

Review Request: qml based kwin shadow

/main.qml efe3ebe kwin/tabbox/qml/tabbox.qml 4176231 Diff: http://git.reviewboard.kde.org/r/108243/diff/ Testing --- all desktop tabbox is tested with Air and Slim Glow, composite and non-composite, no problem. Thanks, Xuetian Weng ___ Plasma

Re: Review Request: qml based kwin shadow

ATION kwin/tabbox/qml/tabbox.qml 4176231 Diff: http://git.reviewboard.kde.org/r/108243/diff/ Testing --- all desktop tabbox is tested with Air and Slim Glow, composite and non-composite, no problem. Thanks, Xuetian Weng ___ Plasma-devel mailing

Re: Review Request: qml based kwin shadow

.10 (current one is half-baked) - Xuetian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/#review24924 ------- On

Re: Review Request: use Plasma::Dialog for icontasks tooltips

instead of use Plasma::Dialog here. - Xuetian Weng On Jan. 7, 2013, 1:53 p.m., Cedric Bellegarde wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: Review Request: qml based kwin shadow

and Slim Glow, composite and non-composite, no problem. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: qml based kwin shadow

desktop tabbox is tested with Air and Slim Glow, composite and non-composite, no problem. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: qml based kwin shadow

tabbox is tested with Air and Slim Glow, composite and non-composite, no problem. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: port kdelib's tooltip shadow code to icontasks, and remove halo

/windowpreview.cpp 94c9eb2 Diff: http://git.reviewboard.kde.org/r/108265/diff/ Testing --- tested, no problem. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

to top, part of window bottom got clipped. As shown in this screenshot (Bottom Left kickoff) http://wstaw.org/m/2013/01/08/plasma-desktopZm7749.png - Xuetian Weng On Jan. 8, 2013, 8:21 a.m., Martin Gräßlin wrote: > > --- > T

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

remain on the screen, screen shot for hiding krunner: http://wstaw.org/m/2013/01/08/exp3_1.png - Xuetian Weng On Jan. 8, 2013, 8:21 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Review Request: fix random battery cumulative data error update upon resume

y say it seems to be fixed. At least this change doesn't do any harm and will reduce useless updateCumulative call. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix KWindowSystem::compositingChanged signal

case KWindowSystem will emit the signal, while KSelectionOwner is not. (And I think KSelectionOwner is correct since I didn't do anything to kwin), and I notice some strange plasma theme change caused by this. Trying to find you why.. - Xuetian Weng On Jan. 5, 2013, 5:08 p.m., Thomas Lü

Re: Review Request: Fix KWindowSystem::compositingChanged signal

> On Jan. 8, 2013, 11:15 p.m., Xuetian Weng wrote: > > after I apply the patch, I notice that in some random unknnow case > > KWindowSystem will emit the signal, while KSelectionOwner is not. (And I > > think KSelectionOwner is correct since I didn't do anything t

Re: Review Request: Fix KWindowSystem::compositingChanged signal

> On Jan. 8, 2013, 11:15 p.m., Xuetian Weng wrote: > > after I apply the patch, I notice that in some random unknnow case > > KWindowSystem will emit the signal, while KSelectionOwner is not. (And I > > think KSelectionOwner is correct since I didn't do anything t

Re: Review Request: Fix KWindowSystem::compositingChanged signal

ystem already calls SelectSelectionInput in constructor, just use the above one and do window == winId and event->selection == net_wm_cm is enough. - Xuetian Weng On Jan. 9, 2013, 12:52 a.m., Thomas Lübking wrote: > > -

Re: Review Request: port kdelib's tooltip shadow code to icontasks, and remove halo

-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108265/#review25031 --- On Jan. 8, 2013, 2:06 p.m., Xuetian Weng wrote: > > ---

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

, yakuake seems have no problem. All problem that I mentioned before is solved. I don't have dual screen setup for now.. may try it later. - Xuetian Weng On Jan. 9, 2013, 7:08 a.m., Martin Gräßlin wrote: > > --- > This is an

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

> On Jan. 9, 2013, 12:51 p.m., Xuetian Weng wrote: > > Test with OpenGL + XRender, both side of screen popup tested, yakuake seems > > have no problem. All problem that I mentioned before is solved. I don't > > have dual screen setup for now.. may try it later. Ok

Review Request: fix layout, resize for pager plasmoid

iff/ Testing --- all problem mentioned are resolved. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: fix layout, resize for pager plasmoid

ets/pager/package/contents/ui/main.qml c3cee23 plasma/desktop/applets/pager/pager.cpp a3c4277 Diff: http://git.reviewboard.kde.org/r/108329/diff/ Testing --- all problem mentioned are resolved. Thanks, Xuetian Weng ___ Plasma-devel mailing l

Review Request: various fix for battery plasmoid

Testing --- tested, no problem. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: various fix for battery plasmoid

which should never be ignored just because a cached value is the current value. - Xuetian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108355/#review25267 -------

Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review25307 --- After several days test, so far no problem here. - Xuetian

Re: Review Request 108414: watch for screen addition/removal and resize

/108375/ , that patch seems already cover this. - Xuetian Weng On Jan. 14, 2013, 5:01 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Review Request 108534: some string in javascript is not extracted

Diffs - plasma/generic/applets/batterymonitor/Messages.sh a40d256 plasma/generic/applets/lock_logout/Messages.sh 67892db Diff: http://git.reviewboard.kde.org/r/108534/diff/ Testing --- Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-

Review Request 108559: some screen locker visual fix

ted. accel key will work for i18n case. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 110065: fix notifcation plasmoid about some undefined data when retreive data from data engine

. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110065: fix notifcation plasmoid about some undefined data when retreive data from data engine

ll related warning is now suppressed, and undefined will not be shown in the same case. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110065: fix notifcation plasmoid about some undefined data when retreive data from data engine

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110065/#review31233 --- On April 17, 2013, 4:57 p.m., Xuetian Weng wrote: > > -

Re: Review Request 110065: fix notifcation plasmoid about some undefined data when retreive data from data engine

946 Diff: http://git.reviewboard.kde.org/r/110065/diff/ Testing --- all related warning is now suppressed, and undefined will not be shown in the same case. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://ma

Review Request 111367: fix rich text in new notification popup

Testing --- send >> from ktp and check notification, all displayed as >>, send > from ktp, > is also correctly displayed. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 111613: Fix suspend and resume

/JobDelegate.qml 97baba5 Diff: http://git.reviewboard.kde.org/r/111613/diff/ Testing --- now resume and suspend works. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 111828: fix link click in notification

/contents/ui/LastNotificationPopup.qml 29a6a2d Diff: http://git.reviewboard.kde.org/r/111828/diff/ Testing --- No problem, and seems the drag operation is not affected (if not dragging from link). test with: notify-send "https://google.com";>test link" Tha

Re: Review Request 112208: KMix qml applet

ttp://git.reviewboard.kde.org//r/112208/#fcomment88> It would be nice to have a line here. svg: widgets/line and element horizontal-line would work here - Xuetian Weng On Aug. 27, 2013, 8:40 a.m., Diego Casella

Re: Review Request 112208: KMix qml applet

<http://git.reviewboard.kde.org/r/112208/#comment28679> if volume is changed from kmix, not from the applet, this would issue a duplicate service call to dataengine. my solution is to add a bool protector to disable this signal if the data change is not from user. - Xuetian Wen

Re: Review Request 112208: KMix qml applet

> On Aug. 28, 2013, 9:10 p.m., Xuetian Weng wrote: > > plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml, line 55 > > <http://git.reviewboard.kde.org/r/112208/diff/1/?file=183953#file183953line55> > > > > if volume is changed from kmix, not fr

Re: Review Request 112208: KMix qml applet

> On Aug. 28, 2013, 9:10 p.m., Xuetian Weng wrote: > > plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml, line 55 > > <http://git.reviewboard.kde.org/r/112208/diff/1/?file=183953#file183953line55> > > > > if volume is changed from kmix, not fr

Re: Review Request 112208: KMix qml applet

> On Aug. 28, 2013, 9:10 p.m., Xuetian Weng wrote: > > plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml, line 55 > > <http://git.reviewboard.kde.org/r/112208/diff/1/?file=183953#file183953line55> > > > > if volume is changed from kmix, not fr

Review Request 126060: Fix krunner crash when open "/"

/locations/locationrunner.cpp cc12965 Diff: https://git.reviewboard.kde.org/r/126060/diff/ Testing --- No more crash. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126060: Fix krunner crash when open "/"

Testing --- No more crash. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

> On Nov. 19, 2015, 2:08 p.m., Matthias Klumpp wrote: > > Did you consider running the whole script with `env -i`, or (likely the > > better idea) run KWin with `env -i`? > > That should sanitize the environment (unset all env vars, except for > > shell-defaults). You could then set exactly the

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

somehow, though, e.g. by placing > the allowed variables in a file or new variable, to make this easier to read. > Apart from that, +1 from me (I'll take a look at other DEs though, maybe > someone has come up with a bettr solution to this issue). > > Xuetian We

Review Request 126357: Workaround a system icon tray issue in bug 352055

://git.reviewboard.kde.org/r/126357/diff/ Testing --- At least fix my problem here locally. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126357: Workaround a system icon tray issue in bug 352055

. Diffs - applets/systemtray/plugin/host.cpp 61e8705 Diff: https://git.reviewboard.kde.org/r/126357/diff/ Testing --- At least fix my problem here locally. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https

Review Request 126513: Refactor kcm touchpad to fix some issue related to hotplug touchpad

to device using libinput driver. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126513: Refactor kcm touchpad to fix some issue related to hotplug touchpad

touchpad -> settings applied to device using libinput driver. unplug -> replug -> settings applied to device using libinput driver. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126513: Refactor kcm touchpad to fix some issue related to hotplug touchpad

uchpad -> applet shows up -> unplug touchpad -> applet hides -> replug touchpad -> touchpad is still disabled, and applet shows up -> enable touhcpad -> applet hides. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 126513: Refactor kcm touchpad to fix some issue related to hotplug touchpad

enable touhcpad -> applet hides. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126548: Kill PowerDevil runner

which is still useful (Though for some reason I can't trigger it here). Maybe merge that part into sessions runner and drop others? - Xuetian Weng On Dec. 28, 2015, 5:22 p.m., Kai Uwe Broulik wrote: > > --- > This is an

Re: Review Request 126513: Refactor kcm touchpad to fix some issue related to hotplug touchpad

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126513/#review90350 --- ping :) - Xuetian Weng On Dec. 25, 2015, 7:02 p.m

Re: Review Request 126513: Refactor kcm touchpad to fix some issue related to hotplug touchpad

l. To reply, visit: https://git.reviewboard.kde.org/r/126513/#review90841 ------- On Dec. 25, 2015, 7:02 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/

Re: Review Request 126513: Refactor kcm touchpad to fix some issue related to hotplug touchpad

d is still disabled, and applet shows up -> enable touhcpad -> applet hides. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126807: Ensure connection to exist before using

> On Jan. 19, 2016, 6:35 p.m., Rajeesh K V wrote: > > I must admit I don't understand the root cause or how m_connection could be > > null, but as this fixes the crash - ship it. > > Andreas Cord-Landwehr wrote: > If I am not mistaken, the root cause is the following: > * XLibTouchpad h

Re: Review Request 126807: Ensure connection to exist before using

> its m_touchpadOffAtom in constructor. I'm not sure with what property it > should be initialized with. Adding Weng Xeutian for more details. > > Xuetian Weng wrote: > If m_display is null, the m_device should be null thus it's not possible > to reach the problematic code. &

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

> On Jan. 22, 2016, 6:11 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 19-23 > > > > > > on syntax: else and endif don't need to repeat the condition any more. > > Also we tend to use the lower case varia

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

tps://git.reviewboard.kde.org/r/126843/#comment62514> Why limit to these desktop anyway? I don't see why this is necessary. (e.g. why not lxqt?) - Xuetian Weng On Jan. 22, 2016, 7:08 p.m., Armin K. wrote: > > --- > This is an aut

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

://bugs.kde.org/show_bug.cgi?id=241557 ? Also, I have impression that if there's a big difference between the size of two tooltip window, it will look bad. - Xuetian Weng On Feb. 2, 2016, 8:51 p.m., Marco Martin wrote: > > --- &

Review Request 127009: Add transparency support to xembedsniproxy

: https://git.reviewboard.kde.org/r/127009/diff/ Testing --- goldendict/skype, both are qt4 apps, now without black background (when not using sni-qt). More tests are welcome. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org

Review Request 127010: use xcb_configure_notify to set tray window size for xembedsniproxy

sni disabled), chromium, goldendict, skype. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127009: Add transparency support to xembedsniproxy

f236e9c xembed-sni-proxy/sniproxy.cpp 3827fdd xembed-sni-proxy/xcbutils.h 5e2b6dc Diff: https://git.reviewboard.kde.org/r/127009/diff/ Testing --- goldendict/skype, both are qt4 apps, now without black background (when not using sni-qt). More tests are welcome. Thanks, Xuetian Weng

Review Request 127014: Avoid ghost entry in xembed sni proxy.

://git.reviewboard.kde.org/r/127014/diff/ Testing --- 358719 is now fixed. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127010: use xcb_configure_notify to set tray window size for xembedsniproxy

://gitlab.com/o9000/tint2/blob/master/src/systray/systraybar.c#L957 Diffs - xembed-sni-proxy/sniproxy.cpp 3827fdd Diff: https://git.reviewboard.kde.org/r/127010/diff/ Testing --- Tested with fcitx(with sni disabled), chromium, goldendict, skype. Thanks, Xuetian Weng

Re: Review Request 127009: Add transparency support to xembedsniproxy

/diff/ Testing --- goldendict/skype, both are qt4 apps, now without black background (when not using sni-qt). More tests are welcome. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 127014: Avoid ghost entry in xembed sni proxy.

happens before we add our event mask to the window attributes. Diffs - xembed-sni-proxy/fdoselectionmanager.h 911df6c xembed-sni-proxy/fdoselectionmanager.cpp f236e9c Diff: https://git.reviewboard.kde.org/r/127014/diff/ Testing --- 358719 is now fixed. Thanks, Xuetian Weng

Review Request 127160: Don't force reload profile when battery status changed

https://git.reviewboard.kde.org/r/127160/diff/ Testing --- not sure if this can causes any regression, but profile is not reset to settings when battery status changed. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 127160: Don't force reload profile when battery status changed

s any regression, but profile is not reset to settings when battery status changed. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127201: Fix svg icon path resolving in IconItem

svg?? introduced in https://git.reviewboard.kde.org/r/126557/ Diffs - src/declarativeimports/core/iconitem.cpp 085f284 Diff: https://git.reviewboard.kde.org/r/127201/diff/ Testing --- tested with qmlscene with Plasma.IconItem. Thanks, Xuetian W

  1   2   3   4   >