[Differential] [Changed Subscribers] D3049: Support passing generic QIcon through PlasmaWindow interface

2016-10-14 Thread apol (Aleix Pol Gonzalez)
apol added inline comments. INLINE COMMENTS > plasmawindowmanagement_interface.cpp:386 > +{ > +m_icon = icon; > +setThemedIconName(m_icon.name()); maybe worth adding a `if (m_icon == icon) return;` REPOSITORY rKWAYLAND KWayland BRANCH plasma-window-icon REVISION DETAIL

[Differential] [Changed Subscribers] D3049: Support passing generic QIcon through PlasmaWindow interface

2016-10-13 Thread roberts (Lindsay Roberts)
roberts added inline comments. INLINE COMMENTS > plasmawindowmanagement.cpp:489 > +n = QT_READ(fd, buf, sizeof buf); > +if (n == -1 && (errno == EAGAIN) && ++retryCount < 1000) { > +usleep(1000); EAGAIN comes from reads of O_NONBLOCK fd's, but this seems to be a