[Differential] [Commented On] D3034: Lockscreen: New session only on switchSessionPage

2016-10-12 Thread subdiff (Roman Gilg) 
subdiff added a comment.


  > but if we have a design I don't want to just ignore it.
  
  Absolutely! I just didn't know about this mockup. Thanks for the link. I was 
looking at the task right here before: https://phabricator.kde.org/T3364

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3034

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, davidedmundson
Cc: colomar, andreask, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3034: Lockscreen: New session only on switchSessionPage

2016-10-12 Thread davidedmundson (David Edmundson) 
davidedmundson added a comment.


  Code is now fine, thanks.
  
  (btw if you do any other changes here, you should probably know about 
  /usr/lib64/libexec/kscreenlocker_greet --testing  - especially if you're 
taking screenshots)
  
  > So there is already a significant deviation from the design.
  
  No there isn't.
  
  FWIW, here is the original design.
  
  https://phabricator.kde.org/M58/179/ 
  It lists New Session and there is a button at the bottom for switching to 
existing sessions.
  
  It's fine for it to change, and I'm personally for the change - but if we 
have a design I don't want to just ignore it.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3034

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, davidedmundson
Cc: colomar, andreask, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas