[Differential] [Commented On] D3051: [applets/notification] Add nullptr check

2016-11-07 Thread mart (Marco Martin) 
mart added a comment.


  any news on this? i don't see issues with the patch, even if obviously kindof 
a workaround

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3051

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik
Cc: mart, sebas, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts

[Differential] [Commented On] D3051: [applets/notification] Add nullptr check

2016-10-16 Thread Martin Gräßlin 
graesslin added a comment.


  In https://phabricator.kde.org/D3051#56876, @sebas wrote:
  
  > So, warn, but don't crash?
  
  
  It might be that this was a local qt self-destruction event. I recompiled Qt 
on Thursday and afterwards everything was broken, especially QtQuick. It might 
be that this was the reason for the null popup here. I'll try another recompile 
next week. In case thinks work again and it's not needed, I'll discard the 
review.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3051

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik
Cc: sebas, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts

[Differential] [Commented On] D3051: [applets/notification] Add nullptr check

2016-10-16 Thread Sebastian Kügler 
sebas added a comment.


  So, warn, but don't crash?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3051

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik
Cc: sebas, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts