[Differential] [Commented On] D4113: Correct inital loading of BorderActivate

2017-01-13 Thread Thomas Lübking 
luebking added a comment.


  The entire parsing is totally not safe against JoeReddiot murking around in 
the config file, I wonder what happens if we pass "-1" and what is " " cast 
as...
  
  One should probably use "parseInt(border, 10);"?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4113

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: luebking, graesslin, mart, plasma-devel, kwin, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4113: Correct inital loading of BorderActivate

2017-01-13 Thread Martin Gräßlin 
graesslin added a comment.


  In https://phabricator.kde.org/D4113#77077, @davidedmundson wrote:
  
  > > isthere a bug # for this?
  >
  > There's a Reddit comment...the new bugzilla.
  
  
  Maybe we need a new bugzilla hook which can automatically reply to reddit 
threads.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4113

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: graesslin, mart, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D4113: Correct inital loading of BorderActivate

2017-01-13 Thread David Edmundson 
davidedmundson added a comment.


  > isthere a bug # for this?
  
  There's a Reddit comment...the new bugzilla.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4113

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas