sebas requested changes to this revision. sebas added a comment. This revision now requires changes to proceed.
Idea in general looks good, I'd rather use QTextStream than std though. Can you change that? INLINE COMMENTS > console.cpp:185 > QJsonDocument doc(KScreen::ConfigSerializer::serializeConfig(m_config)); > - qDebug() << doc.toJson(QJsonDocument::Indented); > + std::cout << doc.toJson(QJsonDocument::Indented).toStdString(); > } In other tools, we use QTextStream for the output, I'd prefer that. See libkscreen/src/doctor.cpp for an example. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D3552 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jbraun, sebas Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas