[Differential] [Updated] D3084: [shell] Support autohide panel on wayland

2016-10-17 Thread bshah (Bhushan Shah)
bshah marked an inline comment as done.
bshah added inline comments.

INLINE COMMENTS

> graesslin wrote in panelview.cpp:651
> do we also need to request the slide for the panel on WAyland?

I don't think so.. because from my testing panel sliding seems to work normally.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3084

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Updated] D3084: [shell] Support autohide panel on wayland

2016-10-17 Thread Martin Gräßlin
graesslin added a comment.


  Wayland side looks good to me.

INLINE COMMENTS

> panelview.cpp:651
>  xcb_change_property(c, XCB_PROP_MODE_REPLACE, winId(), atom->atom, 
> XCB_ATOM_CARDINAL, 32, 1, );
>  KWindowEffects::slideWindow(winId(), slideLocation, -1);
>  }

do we also need to request the slide for the panel on WAyland?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3084

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas