D10039: [WebBrowser Plasmoid] Port to QtWebEngine

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:30c6d4564509: [WebBrowser Plasmoid] Port to QtWebEngine 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10039?vs=27058&id=27219#toc

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10039?vs=27058&id=27219

REVISION DETAIL
  https://phabricator.kde.org/D10039

AFFECTED FILES
  applets/CMakeLists.txt
  applets/webbrowser/CMakeLists.txt
  applets/webbrowser/contents/config/main.xml
  applets/webbrowser/contents/ui/main.qml
  applets/webbrowser/metadata.desktop
  applets/webbrowser/package/contents/config/main.xml
  applets/webbrowser/package/contents/ui/main.qml
  applets/webbrowser/package/metadata.desktop

To: broulik, #plasma, #vdg, davidedmundson, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10039: [WebBrowser Plasmoid] Port to QtWebEngine

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10039

To: broulik, #plasma, #vdg, davidedmundson, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10039: [WebBrowser Plasmoid] Port to QtWebEngine

[Kai Uwe Broulik]

broulik updated this revision to Diff 27058.
broulik added a comment.


  - Fix diff

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10039?vs=27057&id=27058

REVISION DETAIL
  https://phabricator.kde.org/D10039

AFFECTED FILES
  applets/CMakeLists.txt
  applets/webbrowser/CMakeLists.txt
  applets/webbrowser/contents/config/main.xml
  applets/webbrowser/contents/ui/main.qml
  applets/webbrowser/metadata.desktop
  applets/webbrowser/package/contents/config/main.xml
  applets/webbrowser/package/contents/ui/main.qml
  applets/webbrowser/package/metadata.desktop

To: broulik, #plasma, #vdg, davidedmundson, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10039: [WebBrowser Plasmoid] Port to QtWebEngine

[Kai Uwe Broulik]

broulik updated this revision to Diff 27057.
broulik edited the test plan for this revision.
broulik added a comment.


  - Make QtWebEngine optional. Had to move the files into a "package" subdir 
and Phab doesn't see that it's a move..

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10039?vs=25800&id=27057

REVISION DETAIL
  https://phabricator.kde.org/D10039

AFFECTED FILES
  applets/CMakeLists.txt
  applets/webbrowser/contents/config/main.xml
  applets/webbrowser/contents/ui/main.qml
  applets/webbrowser/metadata.desktop
  applets/webbrowser/package/contents/config/main.xml
  applets/webbrowser/package/contents/ui/main.qml
  applets/webbrowser/package/metadata.desktop

To: broulik, #plasma, #vdg, davidedmundson, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10039: [WebBrowser Plasmoid] Port to QtWebEngine

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10039

To: broulik, #plasma, #vdg, davidedmundson, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10039: [WebBrowser Plasmoid] Port to QtWebEngine

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Fantastic! Works much better now. In testing, it looks like this does fix all 
the concerns in 371023.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10039

To: broulik, #plasma, #vdg, davidedmundson, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10039: [WebBrowser Plasmoid] Port to QtWebEngine

[Nathaniel Graham]

ngraham added a comment.


  Looks like it also fixes basically everything in 371023, no? That bug is a 
bit of a hodgepodge, so if it were me, I'd also add BUG: 371023 and ask the 
reporter to file new bugs for any remaining issues.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10039

To: broulik, #plasma, #vdg, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10039: [WebBrowser Plasmoid] Port to QtWebEngine

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:67
> +
> +// TODO use contentsSize but that crashes, now mostly for some sane 
> initial size
> +Layout.preferredWidth: units.gridUnit * 25

QTBUG-65942

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10039

To: broulik, #plasma, #vdg, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10039: [WebBrowser Plasmoid] Port to QtWebEngine

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10039

To: broulik, #plasma, #vdg, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10039: [WebBrowser Plasmoid] Port to QtWebEngine

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  QtWebkit is old, unmaintained, possibly insecure, and also has quite a few 
bugs nowadays.
  This also adds a couple of smaller features while at it:
  
  - Reload button turns into a Stop button while loading
  - Cursor changes shape over links
  - Address bar selects all text when clicked to ease typing a completely new 
address
  - Browser forward/back button on the mouse work

TEST PLAN
  QtWebEngine doesn't auto-zoom to fit as QtWebKit did, so I tried to replicate 
that using zoomFactor.
  Given the security implications and given that dict plasmoid uses QtWebEngine 
also, this could go into 5.12.
  
  - Navigated a couple of pages
  - It remembered the last visited page when plasma is restarted
  - Scrolling with mouse wheel now works
  - Context menus are using QQC plasma style
  
  F5670542: Screenshot_20180123_123100.png 


REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10039

AFFECTED FILES
  applets/webbrowser/contents/ui/main.qml

To: broulik, #plasma, #vdg, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart