kossebau abandoned this revision.
kossebau added a comment.
Discarded for now following discarding of used lib KF5DBusRunner
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10079
To: kossebau, davidedmundson, broulik, mart
Cc: michaelh, ngraham,
kossebau updated this revision to Diff 33251.
kossebau added a comment.
remove explicit cancelling of superseded MatchReply
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10079?vs=33027=33251
BRANCH
portBalooRunnerToKDBusRunner
REVISION DETAIL
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> baloosearchrunner.cpp:79-83
> +// discard any still to-do reply, assuming there is only one instance
> asking
> +// so quickly in a
kossebau updated this revision to Diff 33027.
kossebau retitled this revision from " [Draft] Port baloo krunner plugin to
KDBusRunner" to "[Draft] Port baloo krunner plugin to KDBusRunner".
kossebau added a comment.
update to latest kdbusrunner
REPOSITORY
R120 Plasma Workspace
CHANGES
kossebau added inline comments.
INLINE COMMENTS
> michaelh wrote in baloosearchrunner.cpp:103
> Baloo can also handle these types
>
> - Archive
> - Spreadsheet (also found with type:Document)
> - Presentation (also found with type:Document)
>
> see basicindexingjob
>
michaelh added inline comments.
INLINE COMMENTS
> baloosearchrunner.cpp:103
> +matchInternal(m_searchTerm, QStringLiteral("Video"), i18n("Video"));
> +matchInternal(m_searchTerm, QStringLiteral("Folder"), i18n("Folder"));
> +finishMatching();
Baloo can also handle these types
-
kossebau retitled this revision from "Port baloo krunner plugin to KDBusRunner"
to " [Draft] Port baloo krunner plugin to KDBusRunner".
kossebau edited the summary of this revision.
REPOSITORY
R120 Plasma Workspace
BRANCH
portBalooRunnerToKDBusRunner
REVISION DETAIL
