D10079: [Draft] Port baloo krunner plugin to KDBusRunner

[Friedrich W . H . Kossebau]

kossebau abandoned this revision.
kossebau added a comment.


  Discarded for now following discarding of used lib KF5DBusRunner

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10079

To: kossebau, davidedmundson, broulik, mart
Cc: michaelh, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10079: [Draft] Port baloo krunner plugin to KDBusRunner

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 33251.
kossebau added a comment.


  remove explicit cancelling of superseded MatchReply

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10079?vs=33027=33251

BRANCH
  portBalooRunnerToKDBusRunner

REVISION DETAIL
  https://phabricator.kde.org/D10079

AFFECTED FILES
  CMakeLists.txt
  runners/baloo/CMakeLists.txt
  runners/baloo/baloosearchrunner.cpp
  runners/baloo/baloosearchrunner.h
  runners/baloo/dbusutils_p.h
  runners/baloo/org.kde.krunner1.xml

To: kossebau, davidedmundson, broulik, mart
Cc: michaelh, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10079: [Draft] Port baloo krunner plugin to KDBusRunner

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> baloosearchrunner.cpp:79-83
> +// discard any still to-do reply, assuming there is only one instance 
> asking
> +// so quickly in a row, which also currently has no option to repull 
> outdated requests
> +if (m_matchReply) {
> +m_matchReply->cancel();
>  }

You don't need any of this

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10079

To: kossebau, davidedmundson, broulik, mart
Cc: michaelh, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10079: [Draft] Port baloo krunner plugin to KDBusRunner

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 33027.
kossebau retitled this revision from " [Draft] Port baloo krunner plugin to 
KDBusRunner" to "[Draft] Port baloo krunner plugin to KDBusRunner".
kossebau added a comment.


  update to latest kdbusrunner

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10079?vs=25889=33027

BRANCH
  portBalooRunnerToKDBusRunner

REVISION DETAIL
  https://phabricator.kde.org/D10079

AFFECTED FILES
  CMakeLists.txt
  runners/baloo/CMakeLists.txt
  runners/baloo/baloosearchrunner.cpp
  runners/baloo/baloosearchrunner.h
  runners/baloo/dbusutils_p.h
  runners/baloo/org.kde.krunner1.xml

To: kossebau, davidedmundson, broulik, mart
Cc: michaelh, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10079: [Draft] Port baloo krunner plugin to KDBusRunner

[Friedrich W . H . Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> michaelh wrote in baloosearchrunner.cpp:103
> Baloo can also handle these types
> 
> - Archive
> - Spreadsheet (also found with type:Document)
> - Presentation (also found with type:Document)
> 
> see basicindexingjob 
> 
> Currently those can only be found with  e.g. `$ baloosearch type:Archive`. 
> Please make them available in KRunner too.

I agree those would be useful to cover, too.

Adding suppotr for that though is orthogonal to this patch/work. @michaelh 
please file a bug for this as reminder (or perhaps do a straight patch against 
current master :) ).

REPOSITORY
  R120 Plasma Workspace

BRANCH
  portBalooRunnerToKDBusRunner

REVISION DETAIL
  https://phabricator.kde.org/D10079

To: kossebau, davidedmundson, broulik, mart
Cc: michaelh, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10079: [Draft] Port baloo krunner plugin to KDBusRunner

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> baloosearchrunner.cpp:103
> +matchInternal(m_searchTerm, QStringLiteral("Video"), i18n("Video"));
> +matchInternal(m_searchTerm, QStringLiteral("Folder"), i18n("Folder"));
> +finishMatching();

Baloo can also handle these types

- Archive
- Spreadsheet (also found with type:Document)
- Presentation (also found with type:Document)

see basicindexingjob 

Currently those can only be found with  e.g. `$ baloosearch type:Archive`. 
Please make them available in KRunner too.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  portBalooRunnerToKDBusRunner

REVISION DETAIL
  https://phabricator.kde.org/D10079

To: kossebau, davidedmundson, broulik, mart
Cc: michaelh, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10079: [Draft] Port baloo krunner plugin to KDBusRunner

[Friedrich W . H . Kossebau]

kossebau retitled this revision from "Port baloo krunner plugin to KDBusRunner" 
to " [Draft] Port baloo krunner plugin to KDBusRunner".
kossebau edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  portBalooRunnerToKDBusRunner

REVISION DETAIL
  https://phabricator.kde.org/D10079

To: kossebau, davidedmundson, broulik, mart
Cc: michaelh, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart