D10151: Correction with the & problem in tabs

2018-02-03 Thread Nathaniel Graham
ngraham added a comment.


  Done.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D10151

To: carlavilla, mlaurent, ngraham
Cc: fvogt, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10151: Correction with the & problem in tabs

2018-02-03 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:0ed4aae225c0: Correction with the & problem in tabs 
(authored by carlavilla, committed by ngraham).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10151?vs=26457&id=26458

REVISION DETAIL
  https://phabricator.kde.org/D10151

AFFECTED FILES
  gui/Workspace.cpp

To: carlavilla, mlaurent, ngraham
Cc: fvogt, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10151: Correction with the & problem in tabs

2018-02-03 Thread Nathaniel Graham
ngraham added a comment.


  I'll cherry pick 'em.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D10151

To: carlavilla, mlaurent, ngraham
Cc: fvogt, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10151: Correction with the & problem in tabs

2018-02-03 Thread Fabian Vogt
fvogt reopened this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  This needs to be commited to Plasma/5.12 as well, probably also Plasma/5.8.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D10151

To: carlavilla, mlaurent, ngraham
Cc: fvogt, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10151: Correction with the & problem in tabs

2018-02-03 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:5ce56e6bb5ef: Correction with the & problem in tabs 
(authored by carlavilla, committed by ngraham).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10151?vs=26090&id=26457

REVISION DETAIL
  https://phabricator.kde.org/D10151

AFFECTED FILES
  gui/Workspace.cpp

To: carlavilla, mlaurent, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10151: Correction with the & problem in tabs

2018-02-03 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Much better now, thanks! Works fine.

REPOSITORY
  R106 KSysguard

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10151

To: carlavilla, mlaurent, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10151: Correction with the & problem in tabs

2018-02-02 Thread Nathaniel Graham
ngraham resigned from this revision.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D10151

To: carlavilla, mlaurent
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10151: Correction with the & problem in tabs

2018-02-02 Thread Nathaniel Graham
ngraham edited the summary of this revision.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D10151

To: carlavilla, mlaurent, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10151: Correction with the & problem in tabs

2018-02-02 Thread Sergio Carlavilla
carlavilla retitled this revision from "Solved bug 382512" to "Correction with 
the & problem in tabs".
carlavilla edited the summary of this revision.
carlavilla edited the test plan for this revision.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D10151

To: carlavilla, mlaurent, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10151: Correction with the & problem in tabs

2018-02-02 Thread Sergio Carlavilla
carlavilla added a comment.


  Sorry for my late response, but I've been moving all week.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D10151

To: carlavilla, mlaurent, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart