D10151: Solved bug 382512
mlaurent added a comment. Ping ? REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent, ngraham Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10151: Solved bug 382512
mlaurent added a comment. For patch it seems ok. But Nathaniel is right. Describe how you tested it, add BUG: etc. Otherwise it's a good start :) Thanks. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent, ngraham Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10151: Solved bug 382512
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks for the patch! In general, it's best to title your Phabricator revision with a short description of the change or fix itself, and mention the bug in the Summary section. And when you do so, you'll want to put it in the form of "BUG: 382512" on its own line; this will cause that bugzilla ticket to automatically get closed if and when this lands. The Summary section should also receive a longer explanation of the change, if necessary. Also, please write something in the Test Plan section describing how you tested this change. Thanks again for the patch, and don't hesitate to ask if anything's unclear! REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent, ngraham Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10151: Solved bug 382512
carlavilla created this revision. carlavilla added a reviewer: mlaurent. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. carlavilla requested review of this revision. REVISION SUMMARY Solved the bug with the & in the tabs REPOSITORY R106 KSysguard BRANCH master REVISION DETAIL https://phabricator.kde.org/D10151 AFFECTED FILES gui/Workspace.cpp To: carlavilla, mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
