This revision was automatically updated to reflect the committed changes.
Closed by commit R114:d9d708debf6c: Port mediawiki runner to Plasma5/Qt5
(authored by kossebau).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10184?vs=26662=30363
REVISION
kossebau updated this revision to Diff 26662.
kossebau added a comment.
keep also ampersand with varname, not type, in method signature
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10184?vs=26661=26662
BRANCH
portmediawiki
REVISION DETAIL
kossebau updated this revision to Diff 26661.
kossebau marked an inline comment as done.
kossebau added a comment.
update to kai's feedback
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10184?vs=26208=26661
BRANCH
portmediawiki
REVISION DETAIL
kossebau marked 2 inline comments as done.
kossebau added a comment.
Thanks for first round of review :)
INLINE COMMENTS
> broulik wrote in mediawiki.cpp:134
> Categorized logging, perhaps?
Yes, though I plan to do this later in one concentrated go for all of
kdeplasma-addons, so things
broulik added a comment.
Lgtm
INLINE COMMENTS
> mediawiki.cpp:60
> //FIXME: at the moment KIO doesn't seem to work in threads
> d->manager = new QNetworkAccessManager( this );
> //d->manager = new KIO::AccessManager( this );
Make sure to enable `QNetworkAccessManager`
kossebau updated this revision to Diff 26208.
kossebau added a comment.
rebase to latest master
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10184?vs=26186=26208
BRANCH
portmediawiki
REVISION DETAIL
https://phabricator.kde.org/D10184
kossebau created this revision.
kossebau added reviewers: broulik, jriddell, davidedmundson, sebas.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.
REVISION SUMMARY
Straight initial port of
