meven added inline comments.
INLINE COMMENTS
> view.cpp:247
> -m_plasmaShellSurface->setPanelTakesFocus(true);
> -m_plasmaShellSurface->setRole(PlasmaShellSurface::Role::Panel);
> -//this should be on showEvent, but it was too soon so none of
> those had any e
apol closed this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10197
To: apol, #plasma, davidedmundson
Cc: graesslin, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
graesslin added a comment.
To ensure we don't forget about it I created:
https://bugs.kde.org/show_bug.cgi?id=389964
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10197
To: apol, #plasma, davidedmundson
Cc: graesslin, broulik, ngraham, davidedmundson, pla
graesslin added a comment.
As the commit went into the 5.12 branch we cannot build up on any
functionality not yet available in Dialog.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10197
To: apol, #plasma, davidedmundson
Cc: graesslin, broulik, ngraham,
davidedmundson added a comment.
The old code is clearly wrong.
It calls Dialog::event(event);
that will set up a shellsurface in the expose event
Then we process further and set up a shell surface in the expose event
PlasmaShellSurfaces are shared, but you still have two object
apol added a comment.
Feel free to revert and reopen the bug:
https://bugs.kde.org/show_bug.cgi?id=385693
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10197
To: apol, #plasma, davidedmundson
Cc: graesslin, broulik, ngraham, davidedmundson, plasma-devel,
graesslin added a comment.
I really think this needs to be reverted. Krunner must be a dock, it must be
set to windows go below and it must take focus. This is all functionality not
provided by Plasma::Dialog. Just removing the code doesn't work unfortunately.
I have a hard time understa
graesslin added a comment.
In https://phabricator.kde.org/D10197#201733, @apol wrote:
> In https://phabricator.kde.org/D10197#200479, @graesslin wrote:
>
> > I fear this broke some functionality of KRunner. It is important to be a
dock window! Otherwise KRunner might not be able to go
apol added a comment.
In https://phabricator.kde.org/D10197#200479, @graesslin wrote:
> I fear this broke some functionality of KRunner. It is important to be a
dock window! Otherwise KRunner might not be able to go above fullscreen windows
and won't be on all desktops. Also without bein
graesslin reopened this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
I just verified with KWin's debug console: KRunner window is now marked as
NET::Normal and not as NET::Dock. This is a problem, KRunner needs to be a dock.
REPOSITORY
R120 Plasma Wo
graesslin added a comment.
I fear this broke some functionality of KRunner. It is important to be a dock
window! Otherwise KRunner might not be able to go above fullscreen windows and
won't be on all desktops. Also without being a PlasmaSurface the manual
positioning cannot work. If it works
broulik added inline comments.
INLINE COMMENTS
> view.cpp:246
> -
> m_plasmaShellSurface->setPanelBehavior(PlasmaShellSurface::PanelBehavior::WindowsGoBelow);
> -m_plasmaShellSurface->setPanelTakesFocus(true);
> -m_plasmaShellSurface->setRole(PlasmaShellSurface
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fc5a45403025: Fix krunner's alt+f2 on wayland
(authored by apol).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10197?vs=26233&id=26247
REVISION DETAIL
davidedmundson accepted this revision.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10197
To: apol, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas
apol updated this revision to Diff 26233.
apol added a comment.
Readd the comment
If somebody can test it on X11, I'd merge to 5.12.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10197?vs=26232&id=26233
BRANCH
master
REVISION DETAIL
htt
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
For context, krunner inherits from Dialog.
Dialog does all this stuff. Duplicating it here is wrong.
Must have been ported first or something.
INLINE COMMENTS
> vie
apol updated this revision to Diff 26232.
apol added a comment.
Remove code
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10197?vs=26230&id=26232
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10197
AFFECTED FILES
krunner/view
davidedmundson added inline comments.
INLINE COMMENTS
> view.cpp:236
> if (m_plasmaShell && event->type() == QEvent::Expose) {
> using namespace KWayland::Client;
> auto ee = static_cast(event);
This code here is definitely not designed for X11
REPOSITORY
R120 Plasma Wo
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
Don't go through the workaround introduced for X11 that makes it go mental.
19 matches
Mail list logo
