This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6ab44dcb86b1: [Look and feel KCM] Fix copying color
scheme data (authored by kossebau).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D10259?vs=26399=27313#toc
REPOSITORY
R119 Plasma
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
Looks good to me but I don't feel confident enough to give it a shipit but if
it fixes the unittest and works..
REPOSITORY
R119 Plasma Desktop
BRANCH
fixsettingcolorschemelnf
kossebau added a comment.
Ping?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D10259
To: kossebau, broulik, davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
kossebau added a comment.
Okay, got my test user setup working again and thus finally can test how the
code behaves in real life, next to the unit test.
Turns out that the "bug" is not opposed to the user by some magic things
happening. In the normal usage the new setting is somehow
kossebau added a comment.
Oh, and this fixes the unit test "KcmTest::testKCMSave()" which is failing
since https://phabricator.kde.org/R119:cf49d415e7bb30e98c0e7529e7307d8449b8ffcd
(both in 5.12 and master after yesterday's merge).
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
kossebau edited the summary of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D10259
To: kossebau, broulik, davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
kossebau added a comment.
Another option would be to move the
configGroup.writeEntry("ColorScheme", scheme);
behind the config-copy loop.
But then I would think that we do not want to blend in the kdeglobals config
into the color schemes files data in general, or? There is
kossebau created this revision.
kossebau added reviewers: broulik, davidedmundson, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.
REVISION SUMMARY
Using one argument with
