D10294: Init the icon in ShellClient::init

2018-02-25 Thread Martin Flöser 
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:5795fc8cc04a: Init the icon in ShellClient::init 
(authored by graesslin).
Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10294?vs=26500=28021

REVISION DETAIL
  https://phabricator.kde.org/D10294

AFFECTED FILES
  autotests/integration/internal_window.cpp
  autotests/integration/shell_client_test.cpp
  shell_client.cpp

To: graesslin, #kwin, #plasma, bshah
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D10294: Init the icon in ShellClient::init

2018-02-22 Thread Bhushan Shah 
bshah accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

BRANCH
  init-icon-5.12

REVISION DETAIL
  https://phabricator.kde.org/D10294

To: graesslin, #kwin, #plasma, bshah
Cc: plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, iodelay, bwowk, hardening

D10294: Init the icon in ShellClient::init

2018-02-21 Thread Martin Flöser 
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  ping

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10294

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D10294: Init the icon in ShellClient::init

2018-02-04 Thread Martin Flöser 
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  If the window never provides the appId, we would not get an icon for
  the window. This happens for example for KWin's internal windows which
  don't set the app id as KWin also doesn't have a desktop file. With this
  change the DebugConsole has a window icon in the decoration.

TEST PLAN
  Extended tests and manual verification of DebugConsole

REPOSITORY
  R108 KWin

BRANCH
  init-icon-5.12

REVISION DETAIL
  https://phabricator.kde.org/D10294

AFFECTED FILES
  autotests/integration/internal_window.cpp
  autotests/integration/shell_client_test.cpp
  shell_client.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart