D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"
ngraham planned changes to this revision. ngraham added a comment. Still doesn't actually work right; need to hack on it more. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To: ngraham, #plasma, #plasma_accessibility, mart, aacid, lshoravi Cc: davidedmundson, kde-frameworks-devel, aacid, cfeck, ngraham, plasma-devel, GB_2, ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"
ngraham updated this revision to Diff 48569. ngraham marked an inline comment as done. ngraham added a comment. Rebase on current master, address review comments, fix bugs REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10305?vs=26574&id=48569 BRANCH arcpatch-D10305 REVISION DETAIL https://phabricator.kde.org/D10305 AFFECTED FILES src/declarativeimports/core/tooltip.cpp src/declarativeimports/core/tooltip.h src/declarativeimports/core/tooltipdialog.cpp src/declarativeimports/core/tooltipdialog.h To: ngraham, #plasma, #plasma_accessibility, mart, aacid, lshoravi Cc: davidedmundson, kde-frameworks-devel, aacid, cfeck, ngraham, plasma-devel, GB_2, ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"
ngraham commandeered this revision. ngraham added a reviewer: lshoravi. ngraham added a comment. I'll finish this. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To: ngraham, #plasma, #plasma_accessibility, mart, aacid, lshoravi Cc: davidedmundson, kde-frameworks-devel, aacid, cfeck, ngraham, plasma-devel, GB_2, ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"
ngraham added a comment. @lshoravi are you willing and able to address the above-mentioned issues, or should someone else comandeer the revision and do it themselves? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility, mart, aacid Cc: davidedmundson, kde-frameworks-devel, aacid, cfeck, ngraham, plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"
davidedmundson added a comment. Please also fill in the testing done field. INLINE COMMENTS > tooltip.cpp:162 > +dlg->SetAutoShowHide(m_autoShowHide); > +connect(dlg, &ToolTipDialog:.containtsMouseChanged, this, > &ToolTip::toolTipWindowContainsMouseChangedSlot); > dlg->setVisible(true); doing a connect inside show() probably isn't what you want, you'll connect multiple times. Also that signal name has a typo REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility, mart, aacid Cc: davidedmundson, kde-frameworks-devel, aacid, cfeck, ngraham, plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"
aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. The code doesn't merge, and after fixing that manually that the code doesn't build because you're doing dlg->SetAutoShowHide(m_autoShowHide); and the S is wrong REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility, mart, aacid Cc: kde-frameworks-devel, aacid, cfeck, ngraham, plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, #frameworks
D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"
ngraham added a comment. FYI Linus doesn't have a developer account, so someone will need to commit this for him. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D10304 REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility, mart Cc: cfeck, #frameworks, ngraham, plasma-devel, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"
cfeck resigned from this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility Cc: cfeck, #frameworks, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"
lshoravi updated this revision to Diff 26574. lshoravi added a comment. And with that said, I specified the wrong revision in arc. This should be the correct diff. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10305?vs=26573&id=26574 BRANCH arcpatch-D10304 REVISION DETAIL https://phabricator.kde.org/D10305 AFFECTED FILES src/declarativeimports/core/tooltip.cpp src/declarativeimports/core/tooltip.h src/declarativeimports/core/tooltipdialog.cpp src/declarativeimports/core/tooltipdialog.h To: lshoravi, #plasma, #plasma_accessibility, cfeck Cc: cfeck, #frameworks, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"
lshoravi updated this revision to Diff 26573. lshoravi edited the summary of this revision. lshoravi added a comment. Updated author as per ngrahams suggestion. Diff updated for latest framework (assuming that it turned out correctly.) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10305?vs=26525&id=26573 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10305 AFFECTED FILES applets/taskmanager/package/contents/ui/Task.qml applets/taskmanager/package/contents/ui/main.qml To: lshoravi, #plasma, #plasma_accessibility, cfeck Cc: cfeck, #frameworks, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"
lshoravi edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility, cfeck Cc: cfeck, #frameworks, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"
lshoravi edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility, cfeck Cc: cfeck, #frameworks, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"
cfeck requested changes to this revision. cfeck added a comment. This revision now requires changes to proceed. Please use the summary to describe what the patch does, not why you added it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility, cfeck Cc: cfeck, #frameworks, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"
cfeck retitled this revision from "Framework patch: Moving the mouse over a different application icon immediately changes the window list" to "Fix "Moving the mouse over a different application icon immediately changes the window list"". cfeck edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility Cc: #frameworks, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
