D10316: [Folder View] Let Alt+Enter open properties dialog
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b4f3a883cf91: [Folder View] Let Alt+Enter open properties dialog (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10316?vs=26563=26571 REVISION DETAIL https://phabricator.kde.org/D10316 AFFECTED FILES containments/desktop/package/contents/ui/FolderView.qml containments/desktop/plugins/folder/foldermodel.cpp containments/desktop/plugins/folder/foldermodel.h To: broulik, #plasma, hein Cc: michaelh, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10316: [Folder View] Let Alt+Enter open properties dialog
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10316 To: broulik, #plasma, hein Cc: michaelh, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10316: [Folder View] Let Alt+Enter open properties dialog
michaelh added a comment. Confusion vanished. :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10316 To: broulik, #plasma, hein Cc: michaelh, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10316: [Folder View] Let Alt+Enter open properties dialog
broulik added a comment. This patch is about Folder View (e.g. the desktop icons), not Dolphin REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10316 To: broulik, #plasma, hein Cc: michaelh, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10316: [Folder View] Let Alt+Enter open properties dialog
michaelh added a comment. I'm confused. On my system dolphin already behaves exactly like you described. What did I miss? I also observed when >1 items are selected on Ctrl+Return folders open in new tabs, files open in default application. Can be mixed. With 1 item selected there is no difference between Return and Ctrl+Return. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10316 To: broulik, #plasma, hein Cc: michaelh, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10316: [Folder View] Let Alt+Enter open properties dialog
broulik edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10316 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10316: [Folder View] Let Alt+Enter open properties dialog
broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This is what Dolphin does. The shortcut is hardcoded here and also common on other platforms. TEST PLAN - Selected one file, Alt+Enter, showed properties dialog of that file - Selected two files, Alt+Enter, swhoed properties dialog of both files - Context menu still worked - Running file by keyboard still worked - Both Enter and Return were treated equally REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10316 AFFECTED FILES containments/desktop/package/contents/ui/FolderView.qml containments/desktop/plugins/folder/foldermodel.cpp containments/desktop/plugins/folder/foldermodel.h To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
