D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-16 Thread Igor Cota
icota closed this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10392

To: icota, #kirigami, mart
Cc: ngraham, mart, apol, plasma-devel, davidedmundson, hein


D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-16 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10392

To: icota, #kirigami, mart
Cc: ngraham, mart, apol, plasma-devel, davidedmundson, hein


D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-15 Thread Igor Cota
icota updated this revision to Diff 27292.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10392?vs=27290=27292

REVISION DETAIL
  https://phabricator.kde.org/D10392

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: icota, #kirigami
Cc: ngraham, mart, apol, plasma-devel, davidedmundson, hein


D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-15 Thread Igor Cota
icota added a comment.


  @mart Only as a favour to you for the more elegant solution. Thanks!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10392

To: icota, #kirigami
Cc: ngraham, mart, apol, plasma-devel, davidedmundson, hein


D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-15 Thread Igor Cota
icota updated this revision to Diff 27290.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10392?vs=26783=27290

REVISION DETAIL
  https://phabricator.kde.org/D10392

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: icota, #kirigami
Cc: ngraham, mart, apol, plasma-devel, davidedmundson, hein


D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-15 Thread Marco Martin
mart added a comment.


  that's how i did it locally tough still need fixes
  Item {
  
id: behindItem
parent: listItem
z: -1
//TODO: a global "open" state
enabled: background.x !== 0
  
  do you want to push this yourself?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10392

To: icota, #kirigami
Cc: mart, apol, plasma-devel, davidedmundson, hein


D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-09 Thread Igor Cota
icota added a comment.


  @mart It's quite reproducible. Start kirigami gallery (I did it on Android) 
-- go into 'list view' -- bunch of SwipeListItems there -- tap somewhere to the 
left of the 'swipe icon' (the one you're supposed to drag left) --- you will 
trigger either action 1 or 2 as evidenced by the notification.
  
  @apol background.x is 0 when the item is not 'swiped' to the left and the 
action icons are therefore not exposed.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10392

To: icota, #kirigami
Cc: mart, apol, plasma-devel, davidedmundson, hein


D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-09 Thread Marco Martin
mart added a comment.


  the issue is valid, i'm not sure a check of the item x is a good enough 
assumption.
  
  in what conditions this click trough happens? i can't seem to be able to 
reproduce

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10392

To: icota, #kirigami
Cc: mart, apol, plasma-devel, davidedmundson, hein


D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-09 Thread Aleix Pol Gonzalez
apol added a comment.


  Can you explain a bit better the issue?
  Why aren't they exposed? what do you mean by exposing them?
  Why is x false?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10392

To: icota, #kirigami
Cc: apol, plasma-devel, davidedmundson, mart, hein


D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-08 Thread Igor Cota
icota created this revision.
icota added a reviewer: Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
icota requested review of this revision.

REVISION SUMMARY
  I seem to be able to click through a SwipeListItem's delegate and trigger 
actions that should be out of reach. There are probably better ways to do this 
but this fixes it for me.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10392

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: icota, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein