D10480: align checkable widgets in menu items

2018-02-16 Thread Vlad Zagorodniy
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:f697b07340f3: align checkable widgets in menu items 
(authored by zzag).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10480?vs=27344=27359

REVISION DETAIL
  https://phabricator.kde.org/D10480

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezestyle.cpp

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-16 Thread Hugo Pereira Da Costa
hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Ship it ! 
  Thanks !

REPOSITORY
  R31 Breeze

BRANCH
  center-checkbox

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-16 Thread Vlad Zagorodniy
zzag edited the summary of this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-16 Thread Vlad Zagorodniy
zzag edited the summary of this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-16 Thread Vlad Zagorodniy
zzag updated this revision to Diff 27344.
zzag added a comment.


  delete double space bug fix

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10480?vs=27116=27344

BRANCH
  center-checkbox

REVISION DETAIL
  https://phabricator.kde.org/D10480

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezestyle.cpp

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-16 Thread Vlad Zagorodniy
zzag reclaimed this revision.
zzag added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breezestyle.cpp:4740
> If I understand right, this is the double spacing bug fix. 
> Correct ? Very nice. 
> In principle, it would be better to have it in a separate Review, and a 
> separate commit. 
> This way, if in the future someone wants to revert the margin change, she/he 
> does not revert the bug fix at the same time. Can you do that ? 
> Note that thinking about it, I also like the other fix (the margin width 
> increase), so this will go too.

> This way, if in the future someone wants to revert the margin change, she/he 
> does not revert the bug fix at the same time. Can you do that ?

Yes.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-16 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment.


  In D10480#207511 , @zzag wrote:
  
  > > Here: if you look at the last checkbox (folders first). The distance to 
the left edge is larger to that of the bottom edge, while before they were 
identical.
  >
  > Oh, I haven't noticed that before. To me, that's still fine.
  >
  > > So this really depends on what we want to align with what ...
  >
  > I'd propose to align check boxes between the left edge and icon/text.
  
  
  ok. I agree.
  
  See comments below: if you can split this patch in two (first bug fix, then 
margin width increase, then both can go.
  
  Thanks for the good work !

INLINE COMMENTS

> breezestyle.cpp:4740
> +QRect iconRect;
> +if( showIcon && iconWidth > 0 )
> +{

If I understand right, this is the double spacing bug fix. 
Correct ? Very nice. 
In principle, it would be better to have it in a separate Review, and a 
separate commit. 
This way, if in the future someone wants to revert the margin change, she/he 
does not revert the bug fix at the same time. Can you do that ? 
Note that thinking about it, I also like the other fix (the margin width 
increase), so this will go too.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-15 Thread Vlad Zagorodniy
zzag added a comment.


  > Here: if you look at the last checkbox (folders first). The distance to the 
left edge is larger to that of the bottom edge, while before they were 
identical.
  
  Oh, I haven't noticed that before. To me, that's still fine.
  
  > So this really depends on what we want to align with what ...
  
  I'd propose to align check boxes between the left edge and icon/text. (or 
leave it as it is right now)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-15 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment.


  In D10480#206782 , @zzag wrote:
  
  > Well, I could rework this patch to fix double spacing.
  >
  > Centering of check boxes would involve some changes in margins, which 
should be another diff, right?
  >
  > > positioning appears off with respect to the bottom of the menu, when 
checkboxes is present on the last item of the menu.
  >
  > Hmm, I don't see it. Could you please show where positioning is off?
  
  
  
  
  > F5710626: with-check.png 
  
  Here: if you look at the last checkbox (folders first). The distance to the 
left edge is larger to that of the bottom edge, while before they were 
identical.
  This is because margin width and margin height are different. 
  which in turn is needed for centering. 
  So this really depends on what we want to align with what ...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-15 Thread Vlad Zagorodniy
zzag added a comment.


  Well, I could rework this patch to fix double spacing.
  
  Centering of check boxes would involve some changes in margins, which should 
another diff, right?
  
  > positioning appears off with respect to the bottom of the menu, when 
checkboxes is present on the last item of the menu.
  
  Hmm, I don't see it. Could you please show where positioning is off?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-15 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment.


  Hello,
  I do not think this revision should be abbandonned just yet. 
  The part that takes care of removing double spaces when icon is not present 
(when no icon is present in the menu), should go in.
  The part about increasing the side margins to make the checkboxes centered, 
should still be discussed: It is not clear to me that margins and spacing 
between items should be identical, and for instance see how the positioning 
appears off with respect to the bottom of the menu, when checkboxes is present 
on the last item of the menu.
  One solution to fix this would be to also increase the bottom margins, but 
then in turn that makes the item selection funny. (asymetric top bottom). 
Unless of course one either
  
  - make the selection not extends to the end of the menu any more
  - increase the spacing between items to restore the symmetry.
  
  Bottom line: this is a can of worms.
  
  At the minimum, bugs (double spacing) should be fixed.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-15 Thread Vlad Zagorodniy
zzag abandoned this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-14 Thread Vlad Zagorodniy
zzag added a comment.


  > So 5 does makes sense: there is 1 for the frame, and then 4, that matches 
the spacing. Right ?
  
  Yes, I guess so.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-14 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment.


  
  
  > F5710580: Screenshot_20180214_002713.png 

  > 
  > Why are there only 2 pixels?
  
  Because the darker pixel, around the menu is also part of the menu, not the 
shadow. (meaning, there is a one pixel frame that is rendered in the margin).
  
  > After playing a bit with margin values I've found 5 to be reasonable.
  
  So 5 does makes sense: there is 1 for the frame, and then 4, that matches the 
spacing. Right ?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-13 Thread Vlad Zagorodniy
zzag added a comment.


  F5710626: with-check.png 
  
  F5710628: no-check.png 
  
  F5710630: no-icons.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-13 Thread Vlad Zagorodniy
zzag updated this revision to Diff 27116.
zzag added a comment.


  - try to align check boxes by increasing MenuItem_MarginWidth
  - fix another double space problem

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10480?vs=27072=27116

BRANCH
  center-checkbox

REVISION DETAIL
  https://phabricator.kde.org/D10480

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezestyle.cpp

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-13 Thread Vlad Zagorodniy
zzag added a comment.


  F5710509: a.png 
  
  //Side note: This patch tries to center every checkbox between the left 
border and blue rect(and it also ignores margins.)//
  
  F5710580: Screenshot_20180214_002713.png 

  
  Why are there only 2 pixels?
  
  After playing a bit with margin values I've found 5 to be reasonable.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-13 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment.


  In D10480#205772 , @zzag wrote:
  
  > > In principle it should not be needed. Right ?
  >
  > Yes.
  >
  > > Ifcheckboxes have a fixed size, and if margins would be equal to spacing, 
and if the math are correct, having something laied out as: margin + checkbox + 
spacing + icon + spacing + text would be automatically centered, no ?
  >
  > Well, in theory, yes, it would be centered. But, humans often perceive 
something to be centered when it's not actually centered, for example, in 
typography, letters like "O" or "S" are often put below a baseline. So, maybe, 
checkboxes should be even a little bit closer to icons/text.
  >
  > //Edit
  >  To make things clear: I'm not telling "checkboxes should be closer to 
icons.//
  >
  > At a given moment, here's how things laid out:
  >
  >   margin + checkbox_size + spacing + 1 + [2 + PM_SmallIconSize + 2] + 
spacing + 1 + text
  >
  >
  > Also, why is there the number 1?
  
  
  Yes. That's what needs fixing. I know there are subtleties with rect.left + 
rect.width() vs rect.right(). You can easily loose or gain a +1 there. 
  Also, fonts might not start exactly at the rect depending on hinting, which 
letter is drawn etc. 
  But anyway. This can be investigated, if only by actually drawing the 
relevant rect and see where space is lost, misaligned, etc.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-13 Thread Vlad Zagorodniy
zzag added a comment.


  > In principle it should not be needed. Right ?
  
  Yes.
  
  > Ifcheckboxes have a fixed size, and if margins would be equal to spacing, 
and if the math are correct, having something laied out as: margin + checkbox + 
spacing + icon + spacing + text would be automatically centered, no ?
  
  Well, in theory, yes, it would be centered. But, humans often perceive 
something to be centered when it's not actually centered, for example, in 
typography, letters like "O" or "S" are often put below a baseline. So, maybe, 
checkboxes should be even a little bit closer to icons/text.
  
  At a given moment, here's how things laid out:
  
margin + checkbox_size + spacing + 1 + [2 + PM_SmallIconSize + 2] + spacing 
+ 1 + text
  
  Also, why is there the number 1?
  
  > The reason why I would rather fix the current code than introducing some 
centering, is because centering would automatically hide deeper problems, and 
because it makes the metrics (margin, icon width, spacing), not reflect what 
the code do. Which then introduces confusion and make the code not maintainable.
  
  Agreed.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-13 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment.


  Ok. So, the patch works, but ... there is something fishy here. In principle 
it should not be needed. Right ? 
  Ifcheckboxes have a fixed size, and if margins would be equal to spacing, and 
if the math are correct, having something laied out as: margin + checkbox + 
spacing + icon + spacing + text would be automatically centered, no ? 
  Idem without icon. (and if there is double spacing, then it is a bug).
  At least this is how the code is supposed to work. If not, it should be 
fixed, rather than circomvoluting the issue with some centering. 
  (note that the padding on the icons is disconnected to this: not all icons 
have padding, especially if you change icon theme, so you cannot do anything 
but rely on the icon size.
  
  Bottom line, I would like to investigate the current code (which _should_ 
work), rather than accepting this patch. 
  Or do I miss something ?
  
  The reason why I would rather fix the current code than introducing some 
centering, is because centering would automatically hide deeper problems, and 
because it makes the metrics (margin, icon width, spacing), not reflect what 
the code do. Which then introduces confusion and make the code not maintainable.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-13 Thread Vlad Zagorodniy
zzag updated this revision to Diff 27072.
zzag added a comment.


  fix checkbox aligning when there is no any icon

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10480?vs=27062=27072

BRANCH
  center-checkbox

REVISION DETAIL
  https://phabricator.kde.org/D10480

AFFECTED FILES
  kstyle/breezestyle.cpp

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-13 Thread Vlad Zagorodniy
zzag added a comment.


  > this is because you have to rely on maxIconWidth, even if the current item 
has no icon, when computing the checkbox space.
  
  I've came up with something like this
  
if( showIcon && menuItemOption->maxIconWidth > 0 )
{
int dx = (iconRect.left() - Metrics::CheckBox_Size) / 2;
checkBoxRect.moveLeft( dx );
} else {
int dx = (textRect.left() - Metrics::CheckBox_Size) / 2;
checkBoxRect.moveLeft( dx );
}
  
  so, it centers properly checkboxes in menu items with and without icons
  
  F5709869: f.png 
  
  F5709874: g.png 
  
  //(it can be simplified with a ternary operator)//
  
  is it a good approach?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-13 Thread Vlad Zagorodniy
zzag marked 2 inline comments as done.
zzag added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breezestyle.cpp:4701
> why was this chunk of code moved ? This is unrelated to the change.
> Please try keep the diff to the minimum

To keep it consistent:

1. compute required rectangles
2. align checkbox rect
3. paint text, arrows, etc.

Could you please let it stay here?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-13 Thread Vlad Zagorodniy
zzag updated this revision to Diff 27062.
zzag added a comment.


  delete changes not related to this diff

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10480?vs=27051=27062

BRANCH
  center-checkbox

REVISION DETAIL
  https://phabricator.kde.org/D10480

AFFECTED FILES
  kstyle/breezestyle.cpp

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-13 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment.


  Also, code breaks in the following configurations: 
  F5709787: Screenshot_20180213_142858.png 

  
  (see the incorrect centering of the radio button)
  this is because you have to rely on maxIconWidth, even if the current item 
has no icon, when computing the checkbox space.
  This will maintain the same alignment for the full menu.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-13 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment.


  the diff appears more complex than it actually is because of unrelated 
changes. Please keep the changes to the minimum, this will help reviewing.

INLINE COMMENTS

> breeze.h:70
>  Menu_FrameWidth = 0,
> -MenuItem_MarginWidth = 3,
> +MenuItem_MarginWidth = 4,
>  MenuItem_ItemSpacing = 4,

This change is unrelated with the centering. Should be another patch.

> breezestyle.cpp:4660
>  
> +return true;
>  }

this change is unrelated. Please revert.

> breezestyle.cpp:4701
> +
> +QRect arrowRect(
> +contentsRect.right() - Metrics::MenuButton_IndicatorWidth + 1,

why was this chunk of code moved ? This is unrelated to the change.
Please try keep the diff to the minimum

> breezestyle.cpp:4744
>  
> -checkBoxRect = visualRect( option, checkBoxRect );
> +checkableRect = visualRect( option, checkableRect );
>  

please dont rename variables just for the safe of it, and keep checkboxrect.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-13 Thread Vlad Zagorodniy
zzag edited the summary of this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10480: align checkable widgets in menu items

2018-02-13 Thread Vlad Zagorodniy
zzag created this revision.
zzag added reviewers: Breeze, VDG, hpereiradacosta.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  Some icons in menus have small internal padding. In addition to that,
  `PM_SmallIconSize` is smaller than space left to icons, which results
  in adding space around icons. This all "shifts" check boxes and
  radio buttons to the left side.
  
  So, check boxes and radio buttons have to be centered between icon/text
  and the left border. (we can't rely on margins)
  
  Also, it fixes double space between check boxes and text when icons
  in menus are disabled. (mostly, as a side effect)

TEST PLAN
  - open a context menu with icons and check boxes

REPOSITORY
  R31 Breeze

BRANCH
  center-checkbox

REVISION DETAIL
  https://phabricator.kde.org/D10480

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezestyle.cpp

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart