D10525: Only let the user write the first review if they've actually installed the app
This revision was automatically updated to reflect the committed changes. Closed by commit R134:e6c35b6d5c69: Only let the user write the first review if theyve actually installed the app (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10525?vs=27271=27272#toc REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10525?vs=27271=27272 REVISION DETAIL https://phabricator.kde.org/D10525 AFFECTED FILES discover/qml/ApplicationPage.qml To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10525: Only let the user write the first review if they've actually installed the app
ngraham updated this revision to Diff 27271. ngraham added a comment. Remove the enabled: part of this patch; will manually commit it to 5.12, since it has no string changes REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10525?vs=27207=27271 BRANCH dont-write-first-review-unless-app-is-installed (branched from master) REVISION DETAIL https://phabricator.kde.org/D10525 AFFECTED FILES discover/qml/ApplicationPage.qml To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10525: Only let the user write the first review if they've actually installed the app
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. The enabled part of the patch should be in 5.12. REPOSITORY R134 Discover Software Store BRANCH dont-write-first-review-unless-app-is-installed (branched from master) REVISION DETAIL https://phabricator.kde.org/D10525 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10525: Only let the user write the first review if they've actually installed the app
ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10525 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10525: Only let the user write the first review if they've actually installed the app
ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Previously, you could write the first review for an app even if you didn't have it installed. No longer, with this patch! REPOSITORY R134 Discover Software Store BRANCH dont-write-first-review-unless-app-is-installed (branched from master) REVISION DETAIL https://phabricator.kde.org/D10525 AFFECTED FILES discover/qml/ApplicationPage.qml To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
