D10627: Reduce plasma lock up time to almost nothing
broulik added a comment. It's lookup, not lockup REPOSITORY R120 Plasma Workspace BRANCH polling (branched from master) REVISION DETAIL https://phabricator.kde.org/D10627 To: jtamate, #frameworks, #plasma, davidedmundson Cc: broulik, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10627: Reduce plasma lock up time to almost nothing
jtamate added a comment. May I do the other 2 commits without another revision? REPOSITORY R120 Plasma Workspace BRANCH polling (branched from master) REVISION DETAIL https://phabricator.kde.org/D10627 To: jtamate, #frameworks, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10627: Reduce plasma lock up time to almost nothing
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. This code already has a platform check before adding the native event filter. IMHO we could just make this an assert. But I like your approach too. REPOSITORY R120 Plasma Workspace BRANCH polling (branched from master) REVISION DETAIL https://phabricator.kde.org/D10627 To: jtamate, #frameworks, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10627: Reduce plasma lock up time to almost nothing
jtamate created this revision. jtamate added reviewers: Frameworks, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jtamate requested review of this revision. REVISION SUMMARY CCBUG: 358231 CCBUG: 342056 Even the icon with the number of tasks pending moves from time to time. To reduce the lock up time, a similar patch must be applied also to frameworks/kwindowsystem src/platforms/xcb/kxmessages.cpp frameworks/plasma-framework src/plasma/private/effectwatcher.cpp According to the documentation (and a look to the source code) http://doc.qt.io/qt-5/qabstractnativeeventfilter.html The type of event eventType is specific to the platform plugin chosen at run-time, and can be used to cast message to the right type. On X11, eventType is set to "xcb_generic_event_t", and the message can be casted to a xcb_generic_event_t pointer. The other eventType are "windows_generic_MSG" and "mac_generic_NSEvent". No other eventType starts with an 'x'. TEST PLAN Cut & paste 2000 small files. Before, a lock up of minutes After, a lock up of seconds REPOSITORY R120 Plasma Workspace BRANCH polling (branched from master) REVISION DETAIL https://phabricator.kde.org/D10627 AFFECTED FILES shell/screenpool.cpp To: jtamate, #frameworks, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
