D10723: hide primary display combo when not supported
This revision was automatically updated to reflect the committed changes. Closed by commit R104:cd3b350e0225: hide primary display combo when not supported (authored by sebas). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10723?vs=27721=27835 REVISION DETAIL https://phabricator.kde.org/D10723 AFFECTED FILES kcm/src/widget.cpp kcm/src/widget.h To: sebas, #plasma, dvratil, davidedmundson Cc: kpiwowarski, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10723: hide primary display combo when not supported
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen BRANCH sebas/pcombo REVISION DETAIL https://phabricator.kde.org/D10723 To: sebas, #plasma, dvratil, davidedmundson Cc: kpiwowarski, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10723: hide primary display combo when not supported
sebas created this revision. sebas added reviewers: Plasma, dvratil. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sebas requested review of this revision. REVISION SUMMARY Some backends, for example the kwayland backend, do not support setting the primary display. The backends already make their feature set known so we can just hide it from the UI. It's enough to hide it from the UI since setting it doesn't make any difference, the libkscreen backend will simply ignore it internally, so it's just honest to not show it. BUG:390638 TEST PLAN ran kscreen kcm on both, X11 and wayland platforms, combo and label are shown and hidden as expected REPOSITORY R104 KScreen BRANCH sebas/pcombo REVISION DETAIL https://phabricator.kde.org/D10723 AFFECTED FILES kcm/src/widget.cpp kcm/src/widget.h To: sebas, #plasma, dvratil Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
