D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

2018-03-06 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7e5dff648f01: [Dialog] Remove now obsolete 
KWindowSystem::setState calls (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10769?vs=27851&id=28828

REVISION DETAIL
  https://phabricator.kde.org/D10769

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma, mart
Cc: mart, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

2018-03-05 Thread Marco Martin 
mart added a comment.


  did you try if after removing it, repeatedly showing and hiding, the dialog 
does not appear in the taskbar, even for an instant? (if so, good to go for me)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10769

To: broulik, #plasma
Cc: mart, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

2018-03-05 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10769

To: broulik, #plasma, mart
Cc: mart, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

2018-02-23 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The comment says it's resolved in Qt 5.6.1+ but Frameworks depends on Qt 5.7 
nowadays

TEST PLAN
  Repeatedly opened Kickoff, never had it show up in task bar

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10769

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart