D10890: Don't skip certain recent documents in kicker and taskmanager
This revision was automatically updated to reflect the committed changes. Closed by commit R119:ca96f850efbf: Don't skip certain recent documents in kicker and taskmanager (authored by aleksejshilin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10890?vs=28681&id=29001 REVISION DETAIL https://phabricator.kde.org/D10890 AFFECTED FILES applets/kicker/plugin/actionlist.cpp applets/taskmanager/plugin/backend.cpp To: aleksejshilin, #plasma, broulik, hein Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10890: Don't skip certain recent documents in kicker and taskmanager
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. lgtm REPOSITORY R119 Plasma Desktop BRANCH prepare_for_krecentdocument_fix REVISION DETAIL https://phabricator.kde.org/D10890 To: aleksejshilin, #plasma, broulik, hein Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10890: Don't skip certain recent documents in kicker and taskmanager
aleksejshilin edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10890 To: aleksejshilin, #plasma, broulik, hein Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10890: Don't skip certain recent documents in kicker and taskmanager
aleksejshilin updated this revision to Diff 28681. aleksejshilin marked an inline comment as done. aleksejshilin added a comment. - Use QString::mid() REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10890?vs=28639&id=28681 BRANCH prepare_for_krecentdocument_fix REVISION DETAIL https://phabricator.kde.org/D10890 AFFECTED FILES applets/kicker/plugin/actionlist.cpp applets/taskmanager/plugin/backend.cpp To: aleksejshilin, #plasma, broulik, hein Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10890: Don't skip certain recent documents in kicker and taskmanager
broulik added a comment. lgtm INLINE COMMENTS > actionlist.cpp:312 > +if (storageId.startsWith("org.kde.")) { > +query = query | Agent(storageId.right(storageId.length() - 8)); > +} I would prefer `mid(8)` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10890 To: aleksejshilin, #plasma, broulik, hein Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10890: Don't skip certain recent documents in kicker and taskmanager
hein added a comment. Looks good to me, Kai? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10890 To: aleksejshilin, #plasma, broulik, hein Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10890: Don't skip certain recent documents in kicker and taskmanager
aleksejshilin updated this revision to Diff 28639. aleksejshilin added a comment. - Make sure to forget all documents, too REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10890?vs=28626&id=28639 BRANCH prepare_for_krecentdocument_fix REVISION DETAIL https://phabricator.kde.org/D10890 AFFECTED FILES applets/kicker/plugin/actionlist.cpp applets/taskmanager/plugin/backend.cpp To: aleksejshilin, #plasma, broulik, hein Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10890: Don't skip certain recent documents in kicker and taskmanager
anthonyfieroni added a comment. It looks good to me REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10890 To: aleksejshilin, #plasma, broulik, hein Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10890: Don't skip certain recent documents in kicker and taskmanager
aleksejshilin retitled this revision from "Prepare for KIO KRecentDocument fix (D10863)" to "Don't skip certain recent documents in kicker and taskmanager". aleksejshilin edited the summary of this revision. aleksejshilin edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10890 To: aleksejshilin, #plasma, broulik, hein Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart