D10991: [mpris2 dataengine] Fix media key handling to match MediaPlayer2.Player
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:d62c50d5c678: [mpris2 dataengine] Fix media key handling to match MediaPlayer2.Player (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10991?vs=28796=28815 REVISION DETAIL https://phabricator.kde.org/D10991 AFFECTED FILES dataengines/mpris2/multiplexedservice.cpp To: kossebau, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10991: [mpris2 dataengine] Fix media key handling to match MediaPlayer2.Player
kossebau updated this revision to Diff 28796. kossebau added a comment. call play() and pause() depending on playbackStatus REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10991?vs=28480=28796 BRANCH fixMPRISMediaKeysHandling REVISION DETAIL https://phabricator.kde.org/D10991 AFFECTED FILES dataengines/mpris2/multiplexedservice.cpp To: kossebau, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10991: [mpris2 dataengine] Fix media key handling to match MediaPlayer2.Player
kossebau added a dependent revision: D10972: [RFC] Exposing slideshow to MPRIS controllers. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10991 To: kossebau, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10991: [mpris2 dataengine] Fix media key handling to match MediaPlayer2.Player
kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY - first check CanControl property, as it overrules things - next check each action Can* property, to spare D-Bus call and app activation if false - support CanPause and only call PlayPause is possible, otherwise use Play TEST PLAN Vlc can be controlled by keyboard media keys as before, Gwenview patched to support MPRIS (with CanPause=false) can now be controlled with the Play/Pause media key. REPOSITORY R120 Plasma Workspace BRANCH fixMPRISMediaKeysHandling REVISION DETAIL https://phabricator.kde.org/D10991 AFFECTED FILES dataengines/mpris2/multiplexedservice.cpp To: kossebau, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
