D11003: Fix the Add Source dialog

2018-03-10 Thread Nathaniel Graham 
ngraham added a comment.


  In D11003#222401 , @ach wrote:
  
  > FWIW: My first imprression was that the dialog is too narrow.My 'rule' 
is : the most frequently entered URLs should fit into the dialog without 
scrolling to the left or the right.  In this dialog  the string '.flatpakrepo' 
seems to use already 30 % of the width.  Not left for the rest.
  >
  > Nevertheless great work compared to the status before!  Thx a lot Nate!
  >
  > Achim
  
  
  You might be interested in D11219: Increase the "Add Source" dialog's width 


REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11003

To: ngraham, #discover_software_store, apol
Cc: ach, acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11003: Fix the Add Source dialog

2018-03-10 Thread Achim Bohnet 
ach added a comment.


  FWIW: My first imprression was that the dialog is too narrow.My 'rule' is 
: the most frequently entered URLs should fit into the dialog without scrolling 
to the left or the right.  In this dialog  the string '.flatpakrepo' seems to 
use already 30 % of the width.  Not left for the rest.
  
  Nevertheless great work compared to the status before!  Thx a lot Nate!
  
  Achim

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11003

To: ngraham, #discover_software_store, apol
Cc: ach, acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11003: Fix the Add Source dialog

2018-03-06 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:b623a4afb12f: Fix the Add Source dialog (authored by 
ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11003?vs=28533&id=28821

REVISION DETAIL
  https://phabricator.kde.org/D11003

AFFECTED FILES
  discover/qml/AddSourceDialog.qml

To: ngraham, #discover_software_store, apol
Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11003: Fix the Add Source dialog

2018-03-04 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

BRANCH
  fix-add-source-dialog (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11003

To: ngraham, #discover_software_store, apol
Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11003: Fix the Add Source dialog

2018-03-04 Thread Andrew Crouthamel 
acrouthamel added a comment.


  Nice and clean! I like the change.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11003

To: ngraham, #discover_software_store, apol
Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11003: Fix the Add Source dialog

2018-03-03 Thread Nathaniel Graham 
ngraham edited the test plan for this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11003

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11003: Fix the Add Source dialog

2018-03-03 Thread Nathaniel Graham 
ngraham marked an inline comment as done.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11003

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11003: Fix the Add Source dialog

2018-03-03 Thread Nathaniel Graham 
ngraham updated this revision to Diff 28533.
ngraham added a comment.


  Use `onAccepted:` instead of manually intercepting the [Return] and [Enter] 
keys

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11003?vs=28523&id=28533

BRANCH
  fix-add-source-dialog (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11003

AFFECTED FILES
  discover/qml/AddSourceDialog.qml

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11003: Fix the Add Source dialog

2018-03-03 Thread Nathaniel Graham 
ngraham added a comment.


  In D11003#217814 , @apol wrote:
  
  > Does it work to press Enter and Escape?
  
  
  Yep!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11003

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11003: Fix the Add Source dialog

2018-03-03 Thread Aleix Pol Gonzalez 
apol added a comment.


  Does it work to press Enter and Escape?

INLINE COMMENTS

> AddSourceDialog.qml:62
>  Layout.fillWidth: true
> -Keys.onEnterPressed: newSourceDialog.accept()
> +Keys.onReturnPressed: okButton.clicked()
> +Keys.onEnterPressed: okButton.clicked()

onAccepted:

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11003

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11003: Fix the Add Source dialog

2018-03-03 Thread Nathaniel Graham 
ngraham edited the test plan for this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11003

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11003: Fix the Add Source dialog

2018-03-03 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11003

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11003: Fix the Add Source dialog

2018-03-03 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: Discover Software Store, apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Fix a variety of bugs and usability issues with the Add Source dialog:
  
  - Make the close button actually close the dialog
  - Give the text field focus so you can immediately start typing
  - Make the return key push the Add button
  - Remove needless close symbol in top-right corner
  - Give the buttons icons
  
  BUG: 390148

TEST PLAN
  Tested with Flatpak backend:
  
  - Invalid URLs are rejected
  - Valid URLs that nonetheless don't point to a Flatpak repo trigger an error 
message
  - The close button now closes the dialog
  - The return key presses the Add button

REPOSITORY
  R134 Discover Software Store

BRANCH
  fix-add-source-dialog (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11003

AFFECTED FILES
  discover/qml/AddSourceDialog.qml

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11003: Fix the Add Source dialog

2018-03-03 Thread Nathaniel Graham 
ngraham edited the test plan for this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11003

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart