D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

2018-03-06 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R119:09eba0235b90: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false (authored by kossebau). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

2018-03-06 Thread Friedrich W . H . Kossebau
kossebau edited the summary of this revision. kossebau edited the test plan for this revision. REPOSITORY R119 Plasma Desktop BRANCH fixtaskmanagertooltipformpris REVISION DETAIL https://phabricator.kde.org/D11025 To: kossebau, broulik, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-moha

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

2018-03-06 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH fixtaskmanagertooltipformpris REVISION DETAIL https://phabricator.kde.org/D11025 To: kossebau, broulik, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreute

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

2018-03-05 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 28778. kossebau marked an inline comment as done. kossebau added a comment. don't use Stop for middle button, simply disable if CanPause==false REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11025?vs=28716&id=28

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

2018-03-05 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 28716. kossebau added a comment. use play() & pause() instead of playpause() REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11025?vs=28616&id=28716 BRANCH fixtaskmanagertooltipformpris REVISION DETAIL http

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

2018-03-05 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > ToolTipInstance.qml:349 > +if (canPause) { > +mpris2Source.playPause(mprisSourceName); > +} else if (playing) { Same as with media controller, please do not mi

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

2018-03-05 Thread Kai Uwe Broulik
broulik added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11025 To: kossebau, broulik, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

2018-03-04 Thread Friedrich W . H . Kossebau
kossebau added a dependent revision: D10972: [RFC] Exposing slideshow to MPRIS controllers. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11025 To: kossebau, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

2018-03-04 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 28616. kossebau added a comment. - also disable play/pause icon, not just mousearea - add needed method in main.qml (addition shared with D11007 ) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https:/

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

2018-03-04 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Currently the media controller in the tooltup only works with