broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
The window name and user visible name are not used in the app identification
heuristic, so a change here cannot result in the icon, app id, app name,
generic name, PID or launcher changing.
TEST PLAN
Changed files in Qt Creator, noticed that it also erroneously signals a
geometry change, when I ignored that, I verified that it was the name change
code path updating the label and not the geometry one (which also nukes app
info cache)
Also verified that the icon isn't always signalled to have changed just
because the window name changed (can be expensive for apps where we don't know
the service and have to query the window icon)
Inspected TaskTools namespace and didn't find any use of KWindowInfo (and as
such no use of window name/visible name)
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D11096
AFFECTED FILES
libtaskmanager/xwindowtasksmodel.cpp
To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, mart
