D11195: Use separate config group for each wallpaper plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bb5645d8c6e7: Use separate config group for each wallpaper plugin (authored by aleksejshilin). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11195?vs=2911

D11195: Use separate config group for each wallpaper plugin

aleksejshilin added a comment. In D11195#222490 , @davidedmundson wrote: > typically we'd do cfg = cfg.group("") which IMHO is easier to read Yeah, I like it more, too, but I saw the same styling almost everywhere in shell/ and therefor

D11195: Use separate config group for each wallpaper plugin

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Urgh, I can't read. Sorry. typically we'd do cfg = cfg.group("") which IMHO is easier to read, but this is fine too Thanks REPOSITORY R120 Plasma Workspace BRA

D11195: Use separate config group for each wallpaper plugin

aleksejshilin added a comment. In D11195#222450 , @davidedmundson wrote: > Fix setting cfg twice It's not setting twice, it's creating a nested config group. Or did you mean to use a separate variable each time instead of reusing `cf

D11195: Use separate config group for each wallpaper plugin

davidedmundson added a comment. I see, thanks for the explanation. Fix setting cfg twice, and then I'll approve it REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11195 To: aleksejshilin, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, Z

D11195: Use separate config group for each wallpaper plugin

aleksejshilin added a comment. In D11195#222313 , @davidedmundson wrote: > One could argue keeping the colour persist across wallpapers is a feature, what problems does it cause? It's not limited to colors, that's just a testcase. And un

D11195: Use separate config group for each wallpaper plugin

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. One could argue keeping the colour persist across wallpapers is a feature, what problems does it cause? INLINE COMMENTS > containmentconfigview.cpp:180 >

D11195: Use separate config group for each wallpaper plugin

aleksejshilin created this revision. aleksejshilin added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aleksejshilin requested review of this revision. REVISION SUMMARY Wallpaper plugins were storing their config