D11209: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN
This revision was automatically updated to reflect the committed changes. Closed by commit R129:05b3b8b6d335: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN (authored by kossebau). REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11209?vs=29154&id=30068 REVISION DETAIL https://phabricator.kde.org/D11209 AFFECTED FILES src/decoration_p.h src/decorationbutton_p.h src/decorationbuttongroup_p.h src/decorationshadow_p.h src/private/decoratedclientprivate.cpp src/private/decorationsettingsprivate.cpp To: kossebau, graesslin, davidedmundson Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11209: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN
kossebau created this revision. kossebau added a reviewer: graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Nested classes inherit the visibility of their outer class, so all the KClass::Private symbols have also been exported if the ones of KClass were REPOSITORY R129 Window Decoration Library BRANCH donotleakpimplsymbols REVISION DETAIL https://phabricator.kde.org/D11209 AFFECTED FILES src/decoration_p.h src/decorationbutton_p.h src/decorationbuttongroup_p.h src/decorationshadow_p.h src/private/decoratedclientprivate.cpp src/private/decorationsettingsprivate.cpp To: kossebau, graesslin Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
