D11219: Increase the "Add Source" dialog's width

This revision was automatically updated to reflect the committed changes. Closed by commit R134:53f3ce95e634: Increase the "Add Source" dialog's width (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11219?vs=29371&id=29372

D11219: Increase the "Add Source" dialog's width

ngraham updated this revision to Diff 29371. ngraham added a comment. Stupid caveman fix using the web interface REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11219?vs=29370&id=29371 REVISION DETAIL https://phabricator.kde.org/D11219 AF

D11219: Increase the "Add Source" dialog's width

ngraham updated this revision to Diff 29370. ngraham added a comment. For some reason rebaseing on master pulled in an unrelated appstream change REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11219?vs=29369&id=29370 BRANCH wider-add-sour

D11219: Increase the "Add Source" dialog's width

ngraham updated this revision to Diff 29369. ngraham added a comment. Rebase on master REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11219?vs=29192&id=29369 BRANCH wider-add-source-dialog (branched from master) REVISION DETAIL https:/

D11219: Increase the "Add Source" dialog's width

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I'm not sure. Oh well, land it as is, if it becomes a problem we'll solve it. REPOSITORY R134 Discover Software Store BRANCH wider-add-source-dialog (branched from master) REVISION DETAIL

D11219: Increase the "Add Source" dialog's width

ngraham added a comment. In D11219#223908 , @apol wrote: > I wonder if wit would make sense to make it in terms of the parent size too. Something like: `width: Math.min(gridUnit*20, parent.width * 0.8)` For some reason `Math.min (Kirigami

D11219: Increase the "Add Source" dialog's width

apol added a comment. I wonder if wit would make sense to make it in terms of the parent size too. Something like: `width: Math.min(gridUnit*20, parent.width*0.8)` REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11219 To: ngraham, apol, #discover_sof

D11219: Increase the "Add Source" dialog's width, to accommodate longer repo URLs without cutting anything off

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY As @ach pointed out, even after my last roun