D11801: remove m_desktopContainments

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5898499c1f8f: remove m_desktopContainments (authored by 
mart).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11801?vs=31201=32264

REVISION DETAIL
  https://phabricator.kde.org/D11801

AFFECTED FILES
  shell/shellcorona.cpp
  shell/shellcorona.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11801: remove m_desktopContainments

[Marco Martin]

mart updated this revision to Diff 31201.
mart added a comment.


  - setting activity is base corona's job

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11801?vs=30916=31201

BRANCH
  arcpatch-D11801

REVISION DETAIL
  https://phabricator.kde.org/D11801

AFFECTED FILES
  shell/shellcorona.cpp
  shell/shellcorona.h

To: mart, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11801: remove m_desktopContainments

[David Edmundson]

davidedmundson added a comment.


  Now that previous containmentForScreen patch is looking a thousand times 
better. Good stuff.
  
  +1

INLINE COMMENTS

> shellcorona.cpp:1256
>  if (containment) {
>  containment->setActivity(activity);
>  insertContainment(activity, screenNum, containment);

This shouldn't be needed if we pass it as an arg to containmentForScreen

> shellcorona.cpp:1596
> +Plasma::Containment *oldContainment = containmentForScreen(screen, 
> m_activityController->currentActivity(), QString());
> +qWarning()<<"OLD CONT"<  //no valid containment in given screen, giving up

fix

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11801

To: mart, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11801: remove m_desktopContainments

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  with new corona containment query functions in D11361 
 the data
  copy done in m_desktopContainments is no more necessary: this should
  make things a bit more simple and robust

TEST PLAN
  launched plasmashell, tried to add/remove activities and screens, all keeps 
working

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/m_desktopContainments

REVISION DETAIL
  https://phabricator.kde.org/D11801

AFFECTED FILES
  shell/shellcorona.cpp
  shell/shellcorona.h

To: mart, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart