D11850: modernize: use auto

2018-04-10 Thread David Edmundson
davidedmundson added a comment.


  I was saying you can push this now you've done it, but I wouldnt' go about 
changing other bits of code elsewhere.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11850

To: zzag, #breeze, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D11850: modernize: use auto

2018-04-02 Thread Vlad Zagorodniy
zzag added a comment.


  In D11850#238791 , @davidedmundson 
wrote:
  
  > Fine, but in general I don't think this is a change worth doing in other 
code unless you're changing the code anyway.
  
  
  I can abandon the patch if you're still not sure whether the change worth it. 
I'd like to make it clear that this change would mess git blame output.

REPOSITORY
  R31 Breeze

BRANCH
  modernize-use-auto

REVISION DETAIL
  https://phabricator.kde.org/D11850

To: zzag, #breeze, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D11850: modernize: use auto

2018-04-02 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Fine, but in general I don't think this is a change worth doing in other code 
unless you're changing the code anyway.

REPOSITORY
  R31 Breeze

BRANCH
  modernize-use-auto

REVISION DETAIL
  https://phabricator.kde.org/D11850

To: zzag, #breeze, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D11850: modernize: use auto

2018-03-31 Thread Vlad Zagorodniy
zzag created this revision.
zzag added a reviewer: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.

REPOSITORY
  R31 Breeze

BRANCH
  modernize-use-auto

REVISION DETAIL
  https://phabricator.kde.org/D11850

AFFECTED FILES
  kdecoration/breezebutton.cpp
  kstyle/animations/breezeanimations.cpp
  kstyle/animations/breezedialdata.cpp
  kstyle/animations/breezeheaderviewdata.cpp
  kstyle/animations/breezescrollbardata.cpp
  kstyle/animations/breezescrollbarengine.cpp
  kstyle/animations/breezetabbardata.cpp
  kstyle/breezeframeshadow.cpp
  kstyle/breezemdiwindowshadow.cpp
  kstyle/breezeshadowhelper.cpp
  kstyle/breezesplitterproxy.cpp
  kstyle/breezestyle.cpp
  kstyle/debug/breezewidgetexplorer.cpp

To: zzag, #breeze
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart