D11909: Properly use kpackage_install_package

2018-09-03 Thread Vlad Zagorodniy 
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:45ca8d95d543: Properly use kpackage_install_package 
(authored by zzag).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11909?vs=31238=40899

REVISION DETAIL
  https://phabricator.kde.org/D11909

AFFECTED FILES
  CMakeLists.txt

To: zzag, #breeze, davidedmundson
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11909: properly use kpackage_install_package

2018-05-30 Thread Vlad Zagorodniy 
zzag added a comment.


  Ping.
  
  Also, could someone please explain what's wrong with 
`kpackage_install_bundled_package`?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11909

To: zzag, #breeze
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11909: properly use kpackage_install_package

2018-05-02 Thread Marco Martin 
mart added a comment.


  fine tis version (with kpackage_install_package and not yet the bundled 
version)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11909

To: zzag, #breeze
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11909: properly use kpackage_install_package

2018-04-15 Thread Vlad Zagorodniy 
zzag added a comment.


  Ping.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11909

To: zzag, #breeze
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11909: properly use kpackage_install_package

2018-04-03 Thread Vlad Zagorodniy 
zzag added a subscriber: davidedmundson.
zzag added a comment.


  @davidedmundson in 
https://github.com/KDE/plasma-workspace/commit/450ef5884d9e93e6f0a2df48aae82f9ed239b394
 you said:
  
  > Concept is fine, but currently we have severe CMake issues ...
  
  I've tried `kpackage_install_bundled_package` and it works pretty fine. Or am 
I missing something? (CMake version: 3.10.3)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11909

To: zzag, #breeze
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11909: properly use kpackage_install_package

2018-04-03 Thread Vlad Zagorodniy 
zzag created this revision.
zzag added a reviewer: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  NO_DEPRECATED_WARNING passed as the fifth arg to
  kpackage_install_package disables a deprecation warning. Passing
  anything else does nothing.

REPOSITORY
  R31 Breeze

BRANCH
  silence-kpackage-install-package-deprecation

REVISION DETAIL
  https://phabricator.kde.org/D11909

AFFECTED FILES
  CMakeLists.txt

To: zzag, #breeze
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart