D11983: [potd wallpaper] Config UI: fix spacing between UI elements

This revision was automatically updated to reflect the committed changes. Closed by commit R114:458f4387f825: [potd wallpaper] Config UI: fix spacing between UI elements (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

abetts added a comment. +1 REPOSITORY R114 Plasma Addons BRANCH improvepotdconfigui REVISION DETAIL https://phabricator.kde.org/D11983 To: kossebau, xuetianweng, ngraham, davidedmundson Cc: abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. That looks sane to me visually. The QML change is sane too. REPOSITORY R114 Plasma Addons BRANCH improvepotdconfigui REVISION DETAIL https://phabricator.kde.org/D11983 To:

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

kossebau added a comment. Guess I better leave the rows as they are, to also follow current config UI logic of the plasma-workspace wallpaper plugins. But fixing at least the missing vertical spacing, making it look like this: F5795203: Screenshot_20180406_150633.png

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

kossebau updated this revision to Diff 31486. kossebau added a comment. one step at a time: keep old Rows and just switch to ColumnLayout REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11983?vs=31481=31486 BRANCH improvepotdconfigui REVISION

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

kossebau added a comment. > It's saying the maximum size is the size it currently is; which is true for all values simultaneously. The idea is to make sure the size stays at the value calculated by `formAlignment - units.largeSpacing` (`formAlignment` being injected here by the

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

davidedmundson added inline comments. INLINE COMMENTS > config.qml:68 > QtControls.Label { > +Layout.minimumWidth: width > +Layout.maximumWidth: width This doesn't make sense. It's saying the maximum size is the size it currently is; which is true for all

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

kossebau added a comment. New look: F5795019: Screenshot_20180406_140546.png REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D11983 To: kossebau, xuetianweng Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

kossebau updated this revision to Diff 31481. kossebau added a comment. add missing bump of QtQuick.Controls version for autoresize of comboboxes REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11983?vs=31480=31481 BRANCH improvepotdconfigui

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

kossebau created this revision. kossebau added a reviewer: xuetianweng. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH improvepotdconfigui REVISION