D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:347f43c42b70: Add "Get Wallpaper Plugins..." 
button to Config Desktop dialog (authored by Zren).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12041?vs=32246&id=43256

REVISION DETAIL
  https://phabricator.kde.org/D12041

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: Zren, #plasma, davidedmundson
Cc: mart, abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  though only merge when we're ready.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12041

To: Zren, #plasma, davidedmundson
Cc: mart, abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

[David Edmundson]

davidedmundson added a comment.


  Sorry for the delay
  
  Update: Spoke to kpackage maintainer.
  I'll add an anonymous DBus signal in kpackagetool and a PackageWatcher to 
monitor that.
  
  Then when I get that hooked up, the blocking problem will be solved.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12041

To: Zren, #plasma
Cc: mart, abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

[Marco Martin]

mart added a comment.


  what's the status of this?
  when ready, should go in, together D12040 
 at the beginning of 3.14 vyvle

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12041

To: Zren, #plasma
Cc: mart, abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

[Andres Betts]

abetts added a comment.


  In D12041#247368 , @Zren wrote:
  
  > In D12041#247352 , @abetts wrote:
  >
  > > Why not save the room on the right of the KCM and instead blur the actual 
image in the list? Move the controls closer to that list item? The arrangement 
looks off the way it shows in the screenshots.
  >
  >
  > If you're referring to my inactiveblur wallpaper plugin 
, it's not 
part of the patch.
  >
  > But anyways, blurring the selected image in the file picker is a neat idea. 
I do like having the non blurred image and the blurred image side by side 
though. The UI is slightly modified from the animatedhue config 
, which needed the preview to test the 360* 
colour wheel, so I didn't put much thought into it.
  
  
  Cool!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12041

To: Zren, #plasma
Cc: abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

[Chris Holland]

Zren added a comment.


  In D12041#247352 , @abetts wrote:
  
  > Why not save the room on the right of the KCM and instead blur the actual 
image in the list? Move the controls closer to that list item? The arrangement 
looks off the way it shows in the screenshots.
  
  
  If you're referring to my inactiveblur wallpaper plugin 
, it's not 
part of the patch.
  
  But anyways, blurring the selected image in the file picker is a neat idea. I 
do like having the non blurred image and the blurred image side by side though. 
The UI is slightly modified from the animatedhue config 
, which needed the preview to test the 360* 
colour wheel, so I didn't put much thought into it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12041

To: Zren, #plasma
Cc: abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

[Andres Betts]

abetts added a comment.


  Why not save the room on the right of the KCM and instead blur the actual 
image in the list? Move the controls closer to that list item? The arrangement 
looks off the way it shows in the screenshots.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12041

To: Zren, #plasma
Cc: abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

[David Edmundson]

davidedmundson added a comment.


  Code that here is fine. 
  As you say we need a tidy way to reload that list in order to have this 
mergable. I'll have a think.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12041

To: Zren, #plasma
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

[Chris Holland]

Zren added a comment.


  I'm still unsure how to update the dropdown after you download a new plugin.
  
  I've moved the "open GHNS window" function in plasma-workspace to 
`components/shellprivate/wallpaperplugin`, but I've just noticed the dropdown 
is populated by `configDialog.wallpaperConfigModel`
  
  - 
https://github.com/KDE/plasma-desktop/blob/master/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml#L141
  
  which is populated here:
  
  - 
https://github.com/KDE/plasma-workspace/blob/master/shell/containmentconfigview.cpp#L114

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12041

To: Zren, #plasma
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

[Chris Holland]

Zren updated this revision to Diff 32246.
Zren retitled this revision from "[WIP] Add "Get Wallpaper Plugins..." button 
to Config Desktop dialog" to "Add "Get Wallpaper Plugins..." button to Config 
Desktop dialog".
Zren edited the summary of this revision.
Zren added a comment.


  Change from Wallpaper.Image to the ShellPrivate.WallpaperPlugin

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12041?vs=31700&id=32246

REVISION DETAIL
  https://phabricator.kde.org/D12041

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: Zren, #plasma
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart