D12050: Make automounting work even if StorageAccess is ignored

[Nathaniel Graham]

ngraham added a comment.


  In D12050#242890 , @bruns wrote:
  
  > Well, I really do not like what arc is doing behind my back ...
  
  
  It irritated me too at first, but over time I found that it's fairly logical. 
In general, you just need to:
  
  - Always preview with `arc land --preview` before you land, to make sure you 
know what `arc` is going to do
  - Always make a branch; don't diff from master
  - Always branch from the branch that you want to land it on
  - If you change your mind later and decide to land on a different branch, 
re-base the commit prior to landing it: `git rebase --onto origin/ 
master`
  
  I really do recommend having a look at 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches.
 I and others have done a lot of work to document the behavior so that using 
`arc` shouldn't feel like a huge headache anymore.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12050

To: bruns, ngraham, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12050: Make automounting work even if StorageAccess is ignored

[Stefan Brüns]

bruns added a comment.


  Well, I really do not like what arc is doing behind my back ...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12050

To: bruns, ngraham, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12050: Make automounting work even if StorageAccess is ignored

[Nathaniel Graham]

ngraham added a comment.


  Well it's too late now, but yes, that would have worked (in general, make 
sure to look before you land by first doing `arc land --preview `). By default, `arc` lands the diff on the parent branch, which in 
this case was master.
  
  Arc documentation is at 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches
  
  For now, you can cherry-pick the commit onto the 5.12 branch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12050

To: bruns, ngraham, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12050: Make automounting work even if StorageAccess is ignored

[Stefan Brüns]

bruns added a comment.


  damn, that did not work as expected ... landed on master
  should I just "arc land --onto Plasma/5.12" ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12050

To: bruns, ngraham, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12050: Make automounting work even if StorageAccess is ignored

[Nathaniel Graham]

ngraham added a comment.


  Can you make sure this ends up on the 5.12 branch too?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12050

To: bruns, ngraham, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12050: Make automounting work even if StorageAccess is ignored

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8dedbcdf4197: Make automounting work even if 
StorageAccess is ignored (authored by bruns).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12050?vs=31695=31710

REVISION DETAIL
  https://phabricator.kde.org/D12050

AFFECTED FILES
  solid-device-automounter/kded/DeviceAutomounter.cpp

To: bruns, ngraham, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12050: Make automounting work even if StorageAccess is ignored

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Land on the 5.12 branch, please.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix_automounting_internal

REVISION DETAIL
  https://phabricator.kde.org/D12050

To: bruns, ngraham, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12050: Make automounting work even if StorageAccess is ignored

[Kai Uwe Broulik]

broulik added a comment.


  I did the KF5 port but I don't recall doing that or why it would be there, so 
+1 from me if it fixes that. I don't use automounter so I don't know

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12050

To: bruns, ngraham, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12050: Make automounting work even if StorageAccess is ignored

[Stefan Brüns]

bruns added a comment.


  In D12050#242755 , @ngraham wrote:
  
  > Did you mean BUG: 391706?
  
  
  No, this commit *fixes* 389479, but it is a prerequisite for fixing 391706 
(which is essentially a revert, thus would regress 389479).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12050

To: bruns, ngraham, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12050: Make automounting work even if StorageAccess is ignored

[Nathaniel Graham]

ngraham added a comment.


  Did you mean BUG: 391706?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12050

To: bruns, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12050: Make automounting work even if StorageAccess is ignored

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  There is no reason to make mounting dependent on the StorageAccess.ignore
  flag, which just serves a a hint for visualization.
  
  This change sneaked in when porting to KF5, no justification given.
  
  BUG: 389479

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix_automounting_internal

REVISION DETAIL
  https://phabricator.kde.org/D12050

AFFECTED FILES
  solid-device-automounter/kded/DeviceAutomounter.cpp

To: bruns, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart