D12088: port the ksplash kcm to the new design

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a6761883c8e7: port the ksplash kcm to the new design (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12088?vs=31958=32295 REVISION

D12088: port the ksplash kcm to the new design

mart added a comment. this is an experiment (still full of binding loops) which implements the way we talked about of - frame always 100% wide - cells spacing flexible while resizing https://www.youtube.com/watch?v=bJjESzaUL48 REPOSITORY R119 Plasma Desktop BRANCH

D12088: port the ksplash kcm to the new design

ngraham added a comment. If the buttons are bound to the edges of the chooser thingy, doesn't that make them jump around and have different positions when the window is horizontally resized? https://bugs.kde.org/show_bug.cgi?id=391910 strikes again... REPOSITORY R119 Plasma Desktop

D12088: port the ksplash kcm to the new design

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > somethign something centre buttons Alternative is to maximise the viewport. There was bug report on the cursors KCM about that, but I can't remember what happened.

D12088: port the ksplash kcm to the new design

mart added a comment. like that, tough i don't like how it makes the code become F5805476: Spectacle.b10847.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12088 To: mart, #plasma, #vdg Cc: abetts, davidedmundson,

D12088: port the ksplash kcm to the new design

abetts added a comment. Is there a way that the additional buttons are centered along the bottom edge of the preview? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12088 To: mart, #plasma, #vdg Cc: abetts, davidedmundson, plasma-devel, ragreen, Pitel,

D12088: port the ksplash kcm to the new design

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:60 > > ou can never be sure that the representation is "completed" as the model > > can change at any moment? > > It must know internally as it has that separate populate and add transition. > > It shouldn't need

D12088: port the ksplash kcm to the new design

mart updated this revision to Diff 31958. mart added a comment. - fix minor warnings REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12088?vs=31956=31958 BRANCH phab/ksplashredesign REVISION DETAIL https://phabricator.kde.org/D12088 AFFECTED

D12088: port the ksplash kcm to the new design

mart updated this revision to Diff 31956. mart added a comment. - remove one redundant setcurrentindex REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12088?vs=31901=31956 BRANCH phab/ksplashredesign REVISION DETAIL

D12088: port the ksplash kcm to the new design

davidedmundson added inline comments. INLINE COMMENTS > mart wrote in main.qml:60 > > You shouldn't have told me that :) > > I have one consistent rule about working round Qt bugs, it needs an > > upstream report and a link in the code. > > I am not completely sure is actually a Qt bug... not

D12088: port the ksplash kcm to the new design

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:60 > You shouldn't have told me that :) > > I have one consistent rule about working round Qt bugs, it needs an upstream > report and a link in the code. > > - > > but in any case, your comment doesn't explain

D12088: port the ksplash kcm to the new design

mart updated this revision to Diff 31901. mart added a comment. - remove one redundant setcurrentindex REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12088?vs=31819=31901 BRANCH phab/ksplashredesign REVISION DETAIL

D12088: port the ksplash kcm to the new design

davidedmundson added inline comments. INLINE COMMENTS > mart wrote in main.qml:60 > the onCountChanged connection thinghie it's an hack that serves at startup: > we don't have a signal from listview "i'm done populating" which happens way > after component.oncompleted, so the only way we have

D12088: port the ksplash kcm to the new design

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:60 > redundant given the onCurrentIndexChanged binding above the onCountChanged connection thinghie it's an hack that serves at startup: we don't have a signal from listview "i'm done populating" which happens way

D12088: port the ksplash kcm to the new design

davidedmundson added a comment. I like patches with more red than green. It's a very positive sign ++ Minor comments below INLINE COMMENTS > main.qml:51 > +kcm.selectedPlugin = model.pluginName; > +view.currentIndex = index; > +

D12088: port the ksplash kcm to the new design

mart added a comment. F5802937: Spectacle.E21294.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12088 To: mart, #plasma, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D12088: port the ksplash kcm to the new design

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY redically simplifying the code, port the ksplash kcm to the new design