D12090: port the look and feel kcm to new design

2018-04-16 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0b91f62e6920: port the look and feel kcm to new design 
(authored by mart).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12090?vs=32282&id=32293

REVISION DETAIL
  https://phabricator.kde.org/D12090

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

To: mart, #plasma, #vdg, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12090: port the look and feel kcm to new design

2018-04-16 Thread Marco Martin 
mart updated this revision to Diff 32282.
mart added a comment.


  - remove dead code

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12090?vs=31959&id=32282

BRANCH
  phab/lookandfeelredesign

REVISION DETAIL
  https://phabricator.kde.org/D12090

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

To: mart, #plasma, #vdg
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12090: port the look and feel kcm to new design

2018-04-12 Thread Marco Martin 
mart updated this revision to Diff 31959.
mart added a comment.


  - remove all the useless currentIndex sync

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12090?vs=31900&id=31959

BRANCH
  phab/lookandfeelredesign

REVISION DETAIL
  https://phabricator.kde.org/D12090

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

To: mart, #plasma, #vdg
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12090: port the look and feel kcm to new design

2018-04-11 Thread Marco Martin 
mart updated this revision to Diff 31900.
mart added a comment.


  - remove one redundant setCurrentIndex

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12090?vs=31821&id=31900

BRANCH
  phab/lookandfeelredesign

REVISION DETAIL
  https://phabricator.kde.org/D12090

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

To: mart, #plasma, #vdg
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12090: port the look and feel kcm to new design

2018-04-10 Thread David Edmundson 
davidedmundson added a comment.


  Same comments as the other one.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12090

To: mart, #plasma, #vdg
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12090: port the look and feel kcm to new design

2018-04-10 Thread Marco Martin 
mart added a comment.


  F5802963: Spectacle.eJ4587.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12090

To: mart, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12090: port the look and feel kcm to new design

2018-04-10 Thread Marco Martin 
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  use the new design for the look and feel kcm, together with
  a massive code simplification

TEST PLAN
  pply does work, as preview of themes

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/lookandfeelredesign

REVISION DETAIL
  https://phabricator.kde.org/D12090

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

To: mart, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart