D12117: handle in the top toolbar

2018-04-16 Thread Marco Martin 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:a14d55fc9222: handle in the top toolbar (authored by 
mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D12117?vs=31896=32286#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12117?vs=31896=32286

REVISION DETAIL
  https://phabricator.kde.org/D12117

AFFECTED FILES
  examples/gallerydata/contents/ui/gallery/MultipleColumnsGallery.qml
  examples/simpleexamples/simpleChatApp.qml
  kirigami.qrc
  src/controls/ContextDrawer.qml
  src/controls/OverlayDrawer.qml
  src/controls/Separator.qml
  src/controls/ToolBarApplicationHeader.qml
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/InlineMessage.qml
  src/controls/templates/OverlayDrawer.qml
  src/controls/templates/private/BackButton.qml
  src/controls/templates/private/ContextIcon.qml
  src/controls/templates/private/ForwardButton.qml
  src/controls/templates/private/GenericDrawerIcon.qml
  src/controls/templates/private/MenuIcon.qml
  src/styles/org.kde.desktop/OverlayDrawer.qml

To: mart, #kirigami
Cc: apol, plasma-devel, davidedmundson, mart, hein

D12117: handle in the top toolbar

2018-04-11 Thread Aleix Pol Gonzalez 
apol added a comment.


  Sounds like a brilliant idea. +1

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12117

To: mart, #kirigami
Cc: apol, plasma-devel, davidedmundson, mart, hein

D12117: handle in the top toolbar

2018-04-11 Thread Marco Martin 
mart added a comment.


  F5804379: Spectacle.i12765.png 
  
  F5804381: Spectacle.q12765.png 
  
  F5804383: Spectacle.n12765.png 
  
  F5804386: Spectacle.r12765.png 
  
  F5804389: Spectacle.b12765.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12117

To: mart, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D12117: handle in the top toolbar

2018-04-11 Thread Marco Martin 
mart created this revision.
mart added a reviewer: Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  on desktop when using ToolbarApplicationHeader put the
  drawer handles inside the toolbar, making them look like
  normal buttons

TEST PLAN
  use the SimpleChatApp example as testbed for it

REPOSITORY
  R169 Kirigami

BRANCH
  mart/upperhandle

REVISION DETAIL
  https://phabricator.kde.org/D12117

AFFECTED FILES
  examples/gallerydata/contents/ui/gallery/MultipleColumnsGallery.qml
  examples/simpleexamples/simpleChatApp.qml
  kirigami.qrc
  src/controls/ContextDrawer.qml
  src/controls/OverlayDrawer.qml
  src/controls/Separator.qml
  src/controls/ToolBarApplicationHeader.qml
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/InlineMessage.qml
  src/controls/templates/OverlayDrawer.qml
  src/controls/templates/private/BackButton.qml
  src/controls/templates/private/ContextIcon.qml
  src/controls/templates/private/ForwardButton.qml
  src/controls/templates/private/GenericDrawerIcon.qml
  src/controls/templates/private/MenuIcon.qml
  src/styles/org.kde.desktop/OverlayDrawer.qml

To: mart, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein