D12148: update the wallpaper dialog to the new design

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:c66e998d7b6c: update the wallpaper dialog to the new design (authored by mart). REPOSITORY R120 Plasma Workspace

D12148: update the wallpaper dialog to the new design

mart updated this revision to Diff 32289. mart added a comment. - remove explicit width REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12148?vs=32281=32289 BRANCH phab/wallpaperdialredesign REVISION DETAIL https://phabricator.kde.org/D12148

D12148: update the wallpaper dialog to the new design

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > config.qml:286-287 > +id: wallpapersGrid > anchors.fill: parent > - > -frameVisible: true > -

D12148: update the wallpaper dialog to the new design

abetts added a comment. When you can, can you share a screenshot of the progress? I am so excited to see this! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12148 To: mart, #plasma, #vdg Cc: broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot,

D12148: update the wallpaper dialog to the new design

mart updated this revision to Diff 32281. mart added a comment. - adapt to new design REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12148?vs=31970=32281 BRANCH phab/wallpaperdialredesign REVISION DETAIL https://phabricator.kde.org/D12148

D12148: update the wallpaper dialog to the new design

mart added a comment. In D12148#245289 , @broulik wrote: > Now I don't see any wallpapers in the list > > GridDelegate.qml:63: ReferenceError: view is not defined > > I did update kdeclarative and kirigami before ouch right,

D12148: update the wallpaper dialog to the new design

broulik added a comment. Now I don't see any wallpapers in the list GridDelegate.qml:63: ReferenceError: view is not defined I did update kdeclarative and kirigami before REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12148 To: mart, #plasma,

D12148: update the wallpaper dialog to the new design

abetts added a comment. Looks good to me! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12148 To: mart, #plasma, #vdg Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12148: update the wallpaper dialog to the new design

mart added a comment. F5805373: Spectacle.H23326.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12148 To: mart, #plasma, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D12148: update the wallpaper dialog to the new design

mart created this revision. mart added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY update the wallpaper dialog to the same design as the new KCMS for