D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

2018-04-23 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b8762edefd04: Kicker: Make menus grow (to a limit) if the text doesnt fit on the default… (authored by aacid). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

2018-04-20 Thread Eike Hein
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Alrighty. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D12171 To: aacid, #plasma, hein Cc: fabianr, ngraham, davidedmundson, abetts,

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

2018-04-19 Thread Fabian Riethmayer
fabianr added a comment. What I don't like is that the menus in the different hierarchy levels can have a different size now. To have them in an uniform size gives them a more consistent look. Change all the menus, in all hierarchy levels, to the same dynamic size? REPOSITORY R119

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

2018-04-18 Thread Nathaniel Graham
ngraham added a comment. From localization perspective, this seems important given that some languages generally yield longer strings than others (we get a lot of Bugzilla tickets on this). Also, romance languages tend to put the differentiating part of the string on the end rather than

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

2018-04-18 Thread Albert Astals Cid
aacid added a comment. In D12171#248840 , @hein wrote: > Personally I sort of, well, hate this and it was a very conscious design decision to make the menu widths uniform, so I'd like some more VDG opinions to convince me otherwise first.

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

2018-04-18 Thread David Edmundson
davidedmundson added a comment. > Personally I sort of, well, hate this and it was a very conscious design decision to make the menu widths uniform, so I'd like some more VDG opinions to convince me otherwise first. Worth noting that they only expand *if* they go above the current size

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

2018-04-18 Thread Eike Hein
hein added a comment. Personally I sort of, well, hate this and it was a very conscious design decision to make the menu widths uniform, so I'd like some more VDG opinions to convince me otherwise first. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12171

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

2018-04-13 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12171 To: aacid, #plasma, hein Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

2018-04-13 Thread Albert Astals Cid
aacid added a comment. This is how it looks now F5806642: now.png This is how it looked before F5806645: before.png Notice how quite critical information is missing from the cut text in the old

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

2018-04-13 Thread Albert Astals Cid
aacid created this revision. aacid added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY On my install i have various application names that don't fit on