D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b8762edefd04: Kicker: Make menus grow (to a limit) if the 
text doesnt fit on the default… (authored by aacid).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12171?vs=32047=32866

REVISION DETAIL
  https://phabricator.kde.org/D12171

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemListDelegate.qml
  applets/kicker/package/contents/ui/ItemListView.qml
  applets/kicker/package/contents/ui/MenuRepresentation.qml

To: aacid, #plasma, hein
Cc: fabianr, ngraham, davidedmundson, abetts, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Alrighty.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12171

To: aacid, #plasma, hein
Cc: fabianr, ngraham, davidedmundson, abetts, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

[Fabian Riethmayer]

fabianr added a comment.


  What I don't like is that the menus in the different hierarchy levels can 
have a different size now. To have them in an uniform size gives them a more 
consistent look.
  
  Change all the menus, in all hierarchy levels, to the same dynamic size?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12171

To: aacid, #plasma, hein
Cc: fabianr, ngraham, davidedmundson, abetts, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

[Nathaniel Graham]

ngraham added a comment.


  From  localization perspective, this seems important given that some 
languages generally yield longer strings than others (we get a lot of Bugzilla 
tickets on this). Also, romance languages tend to put the differentiating part 
of the string on the end rather than the beginning.
  
  From a usability perspective, showing all the text (within reason) seems more 
important than rigidly sticking to a single preferred size. Function > form 
(within reason, again).
  
  So +1 from me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12171

To: aacid, #plasma, hein
Cc: ngraham, davidedmundson, abetts, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

[Albert Astals Cid]

aacid added a comment.


  In D12171#248840 , @hein wrote:
  
  > Personally I sort of, well, hate this and it was a very conscious design 
decision to make the menu widths uniform, so I'd like some more VDG opinions to 
convince me otherwise first.
  
  
  Andy said +1 5 days ago.
  
  BTW have you tried it? It tries very hard not to change the menu width at 
all, so as David says most probably you won't even notice it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12171

To: aacid, #plasma, hein
Cc: davidedmundson, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

[David Edmundson]

davidedmundson added a comment.


  > Personally I sort of, well, hate this and it was a very conscious design 
decision to make the menu widths uniform, so I'd like some more VDG opinions to 
convince me otherwise first.
  
  Worth noting that they only expand *if* they go above the current size which 
hasn't changed, so for me and most people after this patch it'll look exactly 
the same as it does now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12171

To: aacid, #plasma, hein
Cc: davidedmundson, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

[Eike Hein]

hein added a comment.


  Personally I sort of, well, hate this and it was a very conscious design 
decision to make the menu widths uniform, so I'd like some more VDG opinions to 
convince me otherwise first.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12171

To: aacid, #plasma, hein
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12171

To: aacid, #plasma, hein
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

[Albert Astals Cid]

aacid added a comment.


  This is how it looks now F5806642: now.png 

  
  This is how it looked before F5806645: before.png 

  
  Notice how quite critical information is missing from the cut text in the old 
screenshot

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12171

To: aacid, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

[Albert Astals Cid]

aacid created this revision.
aacid added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
aacid requested review of this revision.

REVISION SUMMARY
  On my install i have various application names that don't fit on 
units.gridUnit * 14
  so let the list grow if needed. It only grows to a limit, we don't want the 
list to
  be huge for some weirdly long application name.

TEST PLAN
  Use the menu editor to rename Development to Development 
22
  Check the root menu shows all the name
  Search and check the search bar sizing is correct at all times
  Open submenus with applications whose name previously was cut and check now 
it displays correctly
  
  Note: I get 
TextFieldStyle.qml:46:17: QML QQuickItem: Binding loop detected for 
property "implicitHeight"
  when entering text on the search bar, but i can also reproduce this with a 
simple testcase like
  https://paste.kde.org/pi1hopivh so it seems it's not a bug in my code. Also i 
can't see the search
  bar misbehaving so it seems to be "harmless"

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12171

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemListDelegate.qml
  applets/kicker/package/contents/ui/ItemListView.qml
  applets/kicker/package/contents/ui/MenuRepresentation.qml

To: aacid, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart