D13361: Allow Compact view with narrower windows
This revision was automatically updated to reflect the committed changes. Closed by commit R134:0403d9e8a63b: Allow Compact view with narrower windows (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13361?vs=35614&id=35640 REVISION DETAIL https://phabricator.kde.org/D13361 AFFECTED FILES discover/qml/ApplicationsListPage.qml discover/qml/BrowsingPage.qml To: ngraham, apol, #discover_software_store Cc: sharvey, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13361: Allow Compact view with narrower windows
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Doubt it makes any difference, but if it makes you happier, go for it. :P REPOSITORY R134 Discover Software Store BRANCH allow-compact-view-with-narrower-windows (branched from master) REVISION DETAIL https://phabricator.kde.org/D13361 To: ngraham, apol, #discover_software_store Cc: sharvey, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13361: Allow Compact view with narrower windows
ngraham added a comment. It does make me happier! :D REPOSITORY R134 Discover Software Store BRANCH allow-compact-view-with-narrower-windows (branched from master) REVISION DETAIL https://phabricator.kde.org/D13361 To: ngraham, apol, #discover_software_store Cc: sharvey, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13361: Allow Compact view with narrower windows
ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY When the width of the sidebar was reduced, I didn't change the threshold at which the window uses Compact View when it becomes narrower. As a result, Compact View was almost never used in desktop mode, because the threshold at which it triggered was close to the threshold at which the window changes over to mobile view. This patch corrects the issue and allows the window to switch to Compact View more often. TEST PLAN Discover's main window can now be made small and narrow and it will switch more quickly to Compact view: REPOSITORY R134 Discover Software Store BRANCH allow-compact-view-with-narrower-windows (branched from master) REVISION DETAIL https://phabricator.kde.org/D13361 AFFECTED FILES discover/qml/ApplicationsListPage.qml discover/qml/BrowsingPage.qml To: ngraham, apol, #discover_software_store Cc: sharvey, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
