rjvbb updated this revision to Diff 44083.
rjvbb added a comment.
updated for the current git/head.
David: did you perhaps forget to accept the revision (aka, should I have
committed this)?
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14000?vs=37897=44083
REVISION DETAIL
rjvbb updated this revision to Diff 37897.
rjvbb added a comment.
Using QApplication::style()
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14000?vs=37568=37897
REVISION DETAIL
https://phabricator.kde.org/D14000
AFFECTED FILES
plugin/kquickstyleitem.cpp
alexeymin added a comment.
Don't know how much offtopic will be what I'm going to say, but I recently
ran into an issue while packaging QQC2 application in flatpak with
org.kde.Platform//5.9 runtime. My app was functioning perfectly fine in system,
but under flatpak it failed to start with
davidedmundson added a comment.
Please swap qApp->style for QApplication::style as it's static.
Solution is quite clever.
It's risky as any qstyle will always be written assuming it's a QApplication;
but by definition the QQC2 code shields from a lot of the QWidget casting that
would
rjvbb updated this revision to Diff 37568.
rjvbb added a comment.
build on Mac too
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14000?vs=37439=37568
REVISION DETAIL
https://phabricator.kde.org/D14000
AFFECTED FILES
plugin/kquickstyleitem.cpp
plugin/kquickstyleitem_p.h
To:
mart added a comment.
in principle i agree, I would love to be able to use this in
qguiapplications, but are we sure qstyles won't access qapplication? doesn't
this risk to just move the crash?
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
broulik added a comment.
Why, or who, is setting this environment variable? Plasma-integration sets
`QQuickStyle` depending on whether there is a `QApplication` or not, so this
makes no sense.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
rjvbb updated this revision to Diff 37439.
rjvbb edited the summary of this revision.
rjvbb edited the test plan for this revision.
rjvbb added a comment.
Getting the user's desktop style was easier than I thought.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14000?vs=37437=37439
rjvbb created this revision.
rjvbb added a reviewer: Framework: Syntax Highlighting.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
rjvbb requested review of this revision.
REVISION SUMMARY
See https://bugs.kde.org/show_bug.cgi?id=396287
